Skip to content

Feat: gift wrap add custom signer parameter#381

Merged
nogringo merged 1 commit intomasterfrom
feat/gift-wrap-custom-signer
Jan 31, 2026
Merged

Feat: gift wrap add custom signer parameter#381
nogringo merged 1 commit intomasterfrom
feat/gift-wrap-custom-signer

Conversation

@nogringo
Copy link
Collaborator

No description provided.

@nogringo nogringo linked an issue Jan 24, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.43%. Comparing base (07dfd2c) to head (0ae978d).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...lib/domain_layer/usecases/gift_wrap/gift_wrap.dart 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   72.30%   72.43%   +0.13%     
==========================================
  Files         144      144              
  Lines        5585     5586       +1     
==========================================
+ Hits         4038     4046       +8     
+ Misses       1547     1540       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo self-requested a review January 24, 2026 10:07
Copy link
Contributor

@1-leo 1-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@1-leo 1-leo added this to ndk-dev Jan 24, 2026
@1-leo 1-leo moved this to In Progress in ndk-dev Jan 24, 2026
@nogringo nogringo requested a review from frnandu January 24, 2026 12:17
@nogringo nogringo merged commit ede339e into master Jan 31, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Some ndk methods need an optional signer parameter

3 participants