Skip to content

[NWC] add hold invoice support#147

Merged
frnandu merged 8 commits intomasterfrom
nwc-hold-invoices
May 13, 2025
Merged

[NWC] add hold invoice support#147
frnandu merged 8 commits intomasterfrom
nwc-hold-invoices

Conversation

@frnandu
Copy link
Collaborator

@frnandu frnandu commented May 6, 2025 •
edited
Loading

fixes #148
related to getAlby/hub#1298

@1-leo 1-leo added this to ndk-dev May 7, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev May 7, 2025
@frnandu frnandu mentioned this pull request May 7, 2025
Merged
@codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.20755% with 46 lines in your changes missing coverage. Please review.

Project coverage is 71.27%. Comparing base (8ed70f0) to head (d14eb79).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...ackages/ndk/lib/domain_layer/usecases/nwc/nwc.dart 0.00% 16 Missing ⚠️
...yer/usecases/nwc/requests/cancel_hold_invoice.dart 0.00% 7 Missing ⚠️
...yer/usecases/nwc/requests/settle_hold_invoice.dart 0.00% 7 Missing ⚠️
.../lib/domain_layer/usecases/nwc/nwc_connection.dart 0.00% 5 Missing ⚠️
...ib/domain_layer/usecases/nwc/nwc_notification.dart 28.57% 5 Missing ⚠️
...layer/usecases/nwc/requests/make_hold_invoice.dart 0.00% 5 Missing ⚠️
...main_layer/usecases/nwc/requests/make_invoice.dart 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   71.98%   71.27%   -0.72%     
==========================================
  Files         113      116       +3     
  Lines        3851     3895      +44     
==========================================
+ Hits         2772     2776       +4     
- Misses       1079     1119      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frnandu
Copy link
Collaborator Author

frnandu commented May 9, 2025

added support for 1-click flow NWC deeplink nostr-protocol/nips#1777

@frnandu frnandu changed the title add hold invoice support [NWC] add hold invoice support May 9, 2025
@frnandu frnandu merged commit f14c152 into master May 13, 2025
1 of 3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@frnandu frnandu

Labels

None yet

Projects

ndk-dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NWC hold invoice support

2 participants

@frnandu @1-leo