Skip to content

feat: add hold invoices support for LND & LDK#1298

Merged
rolznz merged 52 commits intomasterfrom
feat/hold-invoices
May 26, 2025
Merged

feat: add hold invoices support for LND & LDK#1298
rolznz merged 52 commits intomasterfrom
feat/hold-invoices

Conversation

@frnandu
Copy link
Contributor

@frnandu frnandu commented May 6, 2025

fixes #1295

  • NWC new methods
  • new hold_invoice_accepted notification
  • LND implementation
  • LDK implementation
  • handle self-payments -> feat: add support for self payments for hold invoices #1304
  • Add hold invoice support to JS SDK (@rolznz to do) -> feat: add hold invoice NWC methods and notification type js-sdk#382
  • Draft NIP-47 spec PR -> NIP-47 Add Hold Invoice Support nostr-protocol/nips#1913
  • expiry does not need to be mandatory any more in the spec (add more documentation regarding the expiry field, so that it's more obvious to the developer that it will not guarantee the receiver to be able to settle the invoice and that it should check the deadline timestamp in the notification.)
  • return claim deadline for LDK and LND + documentation about why it's in blocks
  • review if we need to lower the inactive background sync time for LDK (currently 1h) if it could cause issues with hold invoices having a shorter than expected claim deadline - update: I think it's ok for now

@rolznz rolznz mentioned this pull request May 21, 2025
10 tasks
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz merged commit 04fc9c9 into master May 26, 2025
7 of 15 checks passed
@rolznz rolznz deleted the feat/hold-invoices branch May 26, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hold invoices

2 participants