Add minimal integration test for v1 recipe format #4567
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
janjagusch
commented
Aug 7, 2025
beckermr
reviewed
Aug 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
=======================================
Coverage 80.59% 80.59%
=======================================
Files 141 141
Lines 16122 16122
=======================================
Hits 12994 12994
Misses 3128 3128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
janjagusch
commented
Aug 8, 2025
Comment on lines
-8
to
-13
| PYPI_SIMPLE_API_RESPONSE = json.loads( | ||
| Path(__file__) | ||
| .parent.joinpath("resources/pypi_simple_api_response.json") | ||
| .read_text() | ||
| ) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This constant was unused. I took the liberty to clean this up.
…sch/cf-scripts into add-tests-for-v1-recipes
ytausch
approved these changes
Aug 8, 2025
This was referenced Aug 8, 2025
Contributor
Author
Contributor
Author
|
Turned out that we don't need this particular test case for #4567. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple integration test for the new v1 recipe format, ensuring that a pull request for the expected package version is opened. This should serve as a foundation to make the
DependencyUpdateMigratorv1 compatible, as announced here.Making v1 recipes testable required a small refactoring in the
IntegrationTestHelperclass.Description:
Checklist:
Cross-refs, links to issues, etc: