Conversation
For instance bazel run //cup:cup_bin < cup/sample-project/src/main/cup/calculator.cup
This allows: bazel build cup/sample-project:gen_java We don't need the cup-maven-plugin anymore
Reorganize classes to avoid circular deps TODO: Generate LexScan from .flex file (bootstrap)
TODO: yypushStream cannot find symbol
Add skeleton option in jflex() rule
Move GUI in its own package Don't start GUI if there are no cli args [show usage instead]
Test compiles but fails with StreamClosed
Now failing with org.codehaus.plexus.component.repository.exception.ComponentLookupException: java.util.NoSuchElementException
role: org.apache.maven.repository.RepositorySystem
roleHint:
at org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:267)
1) No implementation for org.eclipse.aether.RepositorySystem was bound. while locating org.apache.maven.artifact.resolver.DefaultArtifactResolver
NoClassDefFoundError: org/eclipse/aether/RepositorySystemSession at de.jflex.plugin.maven.JFlexMojoTest.<init>(JFlexMojoTest.java:24) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
Missing XmlStreamReadeer
3) testTestResources(de.jflex.plugin.maven.JFlexMojoTest) java.lang.AssertionError: Test project directory does not exist: /private/var/tmp/_bazel_regisd/7163a9e1c27558e3ee879928afc3313e/sandbox/darwin-sandbox/1/execroot/__main__/bazel-out/darwin-fastbuild/bin/jflex-maven-plugin/src/test/java/de/jflex/plugin/maven/JFlexMojoTest.runfiles/__main__/src/test/projects/single-file-test at org.junit.Assert.fail(Assert.java:88)
com/google/testing/junit/runner/BazelTestRunner : Unsupported major.minor version 52.0
This reverts commit 569812b.
Cirrus has bazel natively
f2b0cf9 to
505f4f7
Compare
WIP: Cannot find bundle for jflex.Messages
The location of the resources inside of the jar file is determined by the project structure. Bazel first looks for Maven's standard directory layout, (a "src" directory followed by a "resources" directory grandchild). If that is not found, Bazel then looks for the topmost directory named "java" or "javatests" (so, for example, if a resource is at <workspace root>/x/java/y/java/z, the path of the resource will be y/java/z. This heuristic cannot be overridden.
| function gjf() { | ||
| directory=$1 | ||
| logi "Checking $directory" | ||
| java -jar $TOOLSDIR/google-java-format.jar --dry-run --set-exit-if-changed $(find $directory -name '*.java') |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
| function gjf() { | ||
| directory=$1 | ||
| logi "Checking $directory" | ||
| java -jar $TOOLSDIR/google-java-format.jar --dry-run --set-exit-if-changed $(find $directory -name '*.java') |
There was a problem hiding this comment.
Quote this to prevent word splitting.
| "$MVN" ${QUIET} -Pfastbuild -pl "$EXTRA_PROJECTS" install | ||
| fi | ||
|
|
||
| cd "$CWD" |
There was a problem hiding this comment.
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
|
|
||
| # TODO(regisd) Define the list of packages via the profile | ||
| logi "Build and install JFlex only (-P fastbuild)" | ||
| cd "$BASEDIR" |
There was a problem hiding this comment.
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
| visibility = ["//visibility:public"], | ||
| exports = [ | ||
| "@com_google_truth_truth//jar", | ||
| # TODO(regisd) This should be a runtime_deps |
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/regisd/jflex/pulls/2. |
| @@ -0,0 +1,11 @@ | |||
| # It's not nice when high-level packages are nested inside their dep | |||
| # TODO(regisd) Move in a higher level different directory | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.