feat: add semver versioning #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-bmitch
requested changes
Oct 27, 2025
Contributor
sudo-bmitch
left a comment
There was a problem hiding this comment.
See the comments for changes needed before I'd want to include this.
daimoniac
pushed a commit
to daimoniac/regclient
that referenced
this pull request
Oct 28, 2025
Author
|
i implemented the changes you proposed in 31190a0.
also, i changed the behavior of |
sudo-bmitch
requested changes
Oct 28, 2025
Contributor
sudo-bmitch
left a comment
There was a problem hiding this comment.
Overall this looks a lot better. Be sure to squash and sign commits.
internal/semver/semver.go
Outdated
Comment on lines
110
to
113
| if v.prerelease < other.prerelease { | ||
| return -1 | ||
| } | ||
| return 1 |
Contributor
There was a problem hiding this comment.
I think the string comparison would miss rc2 < rc15?
daimoniac
pushed a commit
to daimoniac/regclient
that referenced
this pull request
Oct 28, 2025
Signed-off-by: Stefan Knott <stefan.knott@maloon.de>
sudo-bmitch
reviewed
Oct 28, 2025
daimoniac
pushed a commit
to daimoniac/regclient
that referenced
this pull request
Oct 28, 2025
Signed-off-by: Stefan Knott <stefan.knott@maloon.de> implement maintainer feedback from PR regclient#1005 Signed-off-by: Stefan Knott <stefan.knott@maloon.de> implement maintainer feedback from PR regclient#1005 Signed-off-by: Stefan Knott <stefan.knott@maloon.de>
Signed-off-by: Stefan Knott <stefan.knott@maloon.de> implement maintainer feedback from PR regclient#1005 Signed-off-by: Stefan Knott <stefan.knott@maloon.de> implement maintainer feedback from PR regclient#1005 Signed-off-by: Stefan Knott <stefan.knott@maloon.de> semver versioning 2 Signed-off-by: Stefan Knott <stefan.knott@maloon.de>
sudo-bmitch
approved these changes
Nov 2, 2025
Contributor
sudo-bmitch
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
Describe the change
Semantic Version Filtering for Regsync
Regsync now supports semantic versioning (semver) for filtering Docker image tags, similar to Renovate's or python-pips version support. This allows you to sync only specific version ranges instead of relying solely on regex patterns.
Features
How to verify it
run the included version_filter_test.go
amend the configuration as described in
cmd/regsync/version_filter_test.goand give it a spinChangelog text
Please verify and check that the pull request fulfills the following requirements