MutableProxy: do not rebind self for classmethods #6045
Merged
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the method's `__self__` is a class, then we just return the classmethod value directly with no rebinding.
CodSpeed Performance ReportMerging #6045 will improve performances by 4.67%Comparing Summary
Benchmarks breakdown
|
Contributor
Greptile OverviewGreptile SummaryFixed a bug in Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Test as test_mutable_models
participant State as PydanticState
participant Proxy as MutableProxy (state.dc)
participant ModelDC as ModelDC Class
Test->>Proxy: state.dc.from_dict({"foo": "from_dict", "ls": []})
Note over Proxy: __getattribute__("from_dict")
Proxy->>Proxy: Check if callable
Proxy->>Proxy: Get value.__func__ and value.__self__
Proxy->>Proxy: inspect.isclass(value.__self__)?
Note over Proxy: value.__self__ is ModelDC class<br/>(classmethod detected)
Proxy->>Proxy: Skip rebinding, return classmethod as-is
Proxy->>ModelDC: Call from_dict({"foo": "from_dict", "ls": []})
ModelDC->>ModelDC: Create new instance
ModelDC-->>Proxy: Return ModelDC(foo="from_dict", ls=[])
Proxy-->>Test: Return new instance
Note over State: dirty_vars remains empty<br/>(classmethod doesn't mutate state)
|
adhami3310
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the method's
__self__is a class, then we just return the classmethod value directly with no rebinding.