Make oplock_hold_time_ms configurable #5975
Merged
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the oplock hold time configurable and drop the default down to 50% of the configured lock timeout to avoid lock expiration between the lease breaker sleep ending and the coroutine actually getting scheduled for execution.
CodSpeed Performance ReportMerging #5975 will not alter performanceComparing Summary
|
Contributor
Greptile OverviewGreptile SummaryThis PR makes the opportunistic lock hold time configurable via the Key changes:
The change addresses a race condition where the previous 80% threshold could cause locks to expire between the lease breaker sleep ending and coroutine execution. Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant App as Application
participant Env as Environment Variables
participant SMR as StateManagerRedis
participant Lock as Redis Lock
participant LB as Lease Breaker
App->>Env: Read REFLEX_OPLOCK_HOLD_TIME_MS
Env-->>App: Return configured value or 0
App->>SMR: Initialize StateManagerRedis
SMR->>SMR: Call _default_oplock_hold_time_ms()
alt REFLEX_OPLOCK_HOLD_TIME_MS set
SMR->>SMR: Use configured value
else REFLEX_OPLOCK_HOLD_TIME_MS is 0
SMR->>SMR: Calculate lock_expiration // 2
Note over SMR: Default: 50% of lock expiration<br/>(e.g., 5000ms for 10000ms)
end
SMR->>SMR: Validate oplock_hold_time_ms < lock_expiration
alt Validation fails
SMR-->>App: Raise InvalidLockWarningThresholdError
end
App->>SMR: Acquire opportunistic lock
SMR->>Lock: Acquire Redis lock
Lock-->>SMR: Lock acquired
SMR->>LB: Start lease_breaker task
LB->>LB: Calculate lease_break_time<br/>= oplock_hold_time_ms / 1000
Note over LB: Previously: lock_expiration * 0.8 / 1000<br/>Now: configurable oplock_hold_time_ms / 1000
LB->>LB: Sleep for lease_break_time seconds
LB->>Lock: Release lock after sleep
Lock-->>LB: Lock released
LB-->>SMR: Lease breaker completed
|
Comment on lines
+59
to
+61
| return environment.REFLEX_OPLOCK_HOLD_TIME_MS.get() or ( | ||
| _default_lock_expiration() // 2 | ||
| ) |
Contributor
There was a problem hiding this comment.
style: Add a comment explaining the time calculation in human-readable terms, e.g., "# Default to 50% of lock expiration (e.g., 5000ms for 10000ms expiration)"
Suggested change
| return environment.REFLEX_OPLOCK_HOLD_TIME_MS.get() or ( | |
| _default_lock_expiration() // 2 | |
| ) | |
| return environment.REFLEX_OPLOCK_HOLD_TIME_MS.get() or ( | |
| _default_lock_expiration() // 2 # Default to 50% of lock expiration (e.g., 5000ms for 10000ms expiration) | |
| ) |
Context Used: Rule from dashboard - When using time-based calculations in code, include comments that explain the time duration in human... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: reflex/istate/manager/redis.py
Line: 59:61
Comment:
**style:** Add a comment explaining the time calculation in human-readable terms, e.g., "# Default to 50% of lock expiration (e.g., 5000ms for 10000ms expiration)"
```suggestion
return environment.REFLEX_OPLOCK_HOLD_TIME_MS.get() or (
_default_lock_expiration() // 2 # Default to 50% of lock expiration (e.g., 5000ms for 10000ms expiration)
)
```
**Context Used:** Rule from `dashboard` - When using time-based calculations in code, include comments that explain the time duration in human... ([source](https://app.greptile.com/review/custom-context?memory=f12765cb-0537-4be8-81ad-061314e0e5d0))
How can I resolve this? If you propose a fix, please make it concise.
Kastier1
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the oplock hold time configurable and drop the default down to 50% of the configured lock timeout to avoid lock expiration between the lease breaker sleep ending and the coroutine actually getting scheduled for execution.