dialog trigger must have dialog root as its parent #5896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
approved these changes
Oct 16, 2025
CodSpeed Performance ReportMerging #5896 will create unknown performance changesComparing Summary
Footnotes
|
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
Added _valid_parents constraint to DialogTrigger to enforce that it must be a direct child of DialogRoot, following the Radix UI Dialog component structure.
- Prevents runtime errors by validating component hierarchy at build time
- Missing
ClassVartype annotation (should be added for consistency with other components)
Confidence Score: 4/5
- Safe to merge after fixing the type annotation
- The change correctly enforces parent-child relationships for Dialog components, but is missing the
ClassVartype annotation that's used consistently across the codebase - reflex/components/radix/primitives/dialog.py - needs
ClassVartype annotation added
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| reflex/components/radix/primitives/dialog.py | 4/5 | Added parent validation for DialogTrigger - missing ClassVar type annotation |
Sequence Diagram
sequenceDiagram
participant User
participant DialogRoot
participant DialogTrigger
participant Component
User->>DialogRoot: Create dialog.root()
User->>DialogTrigger: Add dialog.trigger() as child
DialogTrigger->>Component: Validate parent relationship
Component->>Component: Check _valid_parents = ["DialogRoot"]
alt Parent is DialogRoot
Component-->>DialogTrigger: Validation passes
DialogTrigger-->>User: Component renders correctly
else Parent is not DialogRoot
Component-->>User: Raise ValueError with message
end
1 file reviewed, 1 comment
|
|
||
| _memoization_mode = MemoizationMode(recursive=False) | ||
|
|
||
| _valid_parents = ["DialogRoot"] |
Contributor
There was a problem hiding this comment.
syntax: missing ClassVar type annotation - should match the pattern used in other components like AccordionItem, SelectTrigger, etc.
Suggested change
| _valid_parents = ["DialogRoot"] | |
| _valid_parents: ClassVar[list[str]] = ["DialogRoot"] |
Prompt To Fix With AI
This is a comment left during a code review.
Path: reflex/components/radix/primitives/dialog.py
Line: 76:76
Comment:
**syntax:** missing `ClassVar` type annotation - should match the pattern used in other components like `AccordionItem`, `SelectTrigger`, etc.
```suggestion
_valid_parents: ClassVar[list[str]] = ["DialogRoot"]
```
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.