-
Notifications
You must be signed in to change notification settings - Fork 1.7k
0816dev #5891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #5891 will create unknown performance changesComparing Summary
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Summary
This PR performs a comprehensive Ruff formatting update across the codebase with version bumps.
Key Changes:
- Bumped version from
0.8.15dev1to0.8.16dev1 - Upgraded Python development version from 3.13 to 3.14 in
.python-version - Updated Ruff from v0.13.3 to v0.14.0 with preview mode enabled
- Added several new lint rule ignores:
CPY001,DOC202,DOC501,DOC502,FURB189 - Removed darglint pre-commit hook
Code Changes:
- Reformatted list comprehensions, dictionary literals, and tuple definitions to use trailing commas and improved alignment per new Ruff rules
- Replaced lambda key functions with
operator.itemgetter()in sorting operations - Added raw string prefixes to regex patterns in
reflex/utils/format.py - Wrapped
get_db_statuswithrun_in_threadin health endpoint for proper async handling - Changed conditional expressions from ternary to
oroperator where appropriate (e.g.,x if x else y→x or y)
The changes are almost entirely formatting-related with no functional impact, following the new Ruff linting rules.
Confidence Score: 4/5
- This PR is safe to merge with low risk - primarily formatting and linting updates
- Score reflects that changes are predominantly automated formatting via Ruff with minimal logic changes. The Python 3.14 development version bump and operator.itemgetter optimizations are safe improvements. Minor concern about Python 3.14 compatibility testing coverage given the project requires Python >=3.10.
- Pay attention to
reflex/app.pyfor therun_in_threadusage and verify Python 3.14 compatibility across the codebase
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .python-version | 4/5 | Python version bumped from 3.13 to 3.14 for development environment |
| pyproject.toml | 4/5 | Version bump to 0.8.16dev1, ruff upgrade to v0.14.0, enabled preview mode, added new lint rules |
| reflex/app.py | 3/5 | Formatting changes, operator.itemgetter usage, run_in_thread wrapper for get_db_status - check async context |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Ruff as Ruff Linter v0.14.0
participant Code as Codebase
participant Tests as Test Suite
Dev->>Code: Bump version to 0.8.16dev1
Dev->>Code: Update Python to 3.14
Dev->>Ruff: Upgrade to v0.14.0 + enable preview
Dev->>Ruff: Add new lint rules (DOC*, FURB189, CPY001)
Ruff->>Code: Format list comprehensions with trailing commas
Ruff->>Code: Align dictionary literals
Ruff->>Code: Add raw strings to regex patterns
Ruff->>Code: Replace lambda with operator.itemgetter
Ruff->>Code: Optimize ternary to or operator
Dev->>Code: Wrap get_db_status with run_in_thread
Note over Code: Health endpoint now uses async thread wrapper
Dev->>Tests: Update test formatting
Tests-->>Dev: All tests pass
Code-->>Dev: Formatting complete, ready for review
79 files reviewed, no comments
masenf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditch the starmap change and the math.pi stuff and we can bring it
No description provided.