Conversation
nwittwer
added a commit
that referenced
this pull request
Mar 14, 2023
* Added TS and separate package for extraResources (injected `preload` script) * Moved rest of /extraResources to .ts * Updated yarn scripts to run preload TS workflow * Updated builder.config to copy extraResources dir * Updated injectScriptPath in WebView and options for WebView * Add try/catch for loading main Electron window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preloadscript forWebView(WebPage.vue) which was not being loaded in production build. Now the previous functionalities, such as synchronized scrolling will work again.src/extraResources, which will automatically re-build the/extraResourcesto the/dist/extraResourcesdirectory as a.js. This file can then be used forpreloadinside theWebViewtag.