Refactor/pinia#235
Merged
nwittwer merged 61 commits intoimprovement/canvas-interactionfrom Feb 25, 2023
Merged
Conversation
3 tasks
…nd when user hovers over the list, they are highlighted in the DOM
…ersisted store state
…ead of just replacing object inside of array
…and when selected
nwittwer
added a commit
that referenced
this pull request
Mar 1, 2023
* Improved UI for resizing * Reverted to allowing multiple interaction types without switch * WIP web/app interaction contexts * Updated packages * Upgrade from @simonwep/selection-js to @viselect/vanilla * WIP added useEventListener and changing Store interactions * Fixed CSS issue with artboards stretching to flexbox parent height * WIP improving interaction between panzoom and selection * Updated packages * v0.7.0-beta.23 * Updated yarn.lock * Updated Yarn version * message queue * Updated Nuxt/Vue 2.7 and added Lodash, fixed tsconfig Vue errors * Removed event.preventDefault from Panzoom, so it doesn't block event bubbling * Added EventHandler component to Artboards * Refactored and added more logic for handling mouse and CTRL/CMD events * Temporarily disable CrossBrowserScreenshots.vue * Re-add Vuex * Converted from Vue component to a Vue Composable (Composition API function) * Remove unused code * Updated Selection options * Refactor/pinia (#235) * Refactored store/interactions to Pinia * Disabled Vuex-persist plugin * Added PInia to Nuxt 2 * WIP refactored Panzoom.vue to <setup> Composition API * Refactored store/artboards to TS & Pinia * Refactored store/dev to TS & Pinia * Refactored store/focusMode in TS and Pinia * Refactored gui, history, hoverArtboard, interactions, selectedArtboards to TS & Pinia * Added @pinia-plugin-persistedstate for Pinia persisted state * Fixes and improvements to stores * Changed rightClickMenu to TS and use Pinia stores * Added Pinia store to FocusArtboard * Fixed incorrect function calls and use getCurrentInstance.proxy for Panzoom.vue * Refactored PanzoomControls in TS and use Pinia store * Refactored Artboards w/ Pinia, TS, <script setup> * Refactored Artboard w/ <script setup>, TS, Pinia * Refactored screenshot w/ Pinia, TS, <script setup> * Added pinia to artboardeditable * Refactored SidePanel to TS, Pinia, script setup * Refactored ToolBar to TS, script setup, Pinia * Refactored URLInput to TS and Pinia * Migrated more calls to Pinia and fixed wrong variable usage * Removed data prop from artboardEditable and added TS * Added Pinia types * Replaced "state" with "this" (Pinia fix) * More Pinia app usage updates * Updated nuxt types, vueuse, vue (2.7->2.7.14) * Added local TypeScript version to avoid VSCode Volar plugin failing * Changed nuxt "env" to "publicRuntimeConfig" * Added lodash types * Refactored Panzoom.vue, but having race conditions for the mouse/keyboard events * Fixed reference to prop in artboard.vue * Refactored Artboards.vue * Tidied up nuxt.config * Updated yarn lock * Added DevModeHud to see app state in dev mode * Added DevListeners.vue to show all EventListeners in the app * Added canDragSelect event to useEventHandler * Minor improvements to store/artboards.ts * Fixed bug in store/dev * Replaced WebPage.vue's Vuex calls with Pinia * Fixed mapState config for URLInput.vue * Migrated artboardEditable's Vuex call to Pinia * Simplified index.vue * Finished DevListeners, which is able to get all the event listeners and when user hovers over the list, they are highlighted in the DOM * Re-added pinia-plugin-persistedstate-2, which works with Nuxt 2 for persisted store state * Fixed reference to prop that was a string but should have been a data ref * Refactored last Vuex calls to Pinia * Fixed toggleGui() in store/gui * Fixed reactivity bug w/ Pinia in store/artboards using Vue.set() instead of just replacing object inside of array * Fixed double "this.this" reference in store/history * Removed unused SyncButton * Fixed ability to scroll across multiple WebPages * Added missing computed() around imported Store variables in <Artboards> * Fixed isHover from a function to a computed value <Arboard> * Improved resizing interaction and styling of <Artboard> during hover and when selected * Replaced Pinia $subscribe() with $onAction, which is more like Vuex's $subscribe * Changed remaining .commit() in WebPage to use Pinia * Refactored enableSelections and createSelectionInstance * Fixed @keyup assignment from 2 comma-separated functions into just one function
nwittwer
added a commit
that referenced
this pull request
Mar 14, 2023
* Improved UI for resizing * Reverted to allowing multiple interaction types without switch * WIP web/app interaction contexts * Updated packages * Upgrade from @simonwep/selection-js to @viselect/vanilla * WIP added useEventListener and changing Store interactions * Fixed CSS issue with artboards stretching to flexbox parent height * WIP improving interaction between panzoom and selection * Updated packages * v0.7.0-beta.23 * Updated yarn.lock * Updated Yarn version * message queue * Updated Nuxt/Vue 2.7 and added Lodash, fixed tsconfig Vue errors * Removed event.preventDefault from Panzoom, so it doesn't block event bubbling * Added EventHandler component to Artboards * Refactored and added more logic for handling mouse and CTRL/CMD events * Temporarily disable CrossBrowserScreenshots.vue * Re-add Vuex * Converted from Vue component to a Vue Composable (Composition API function) * Remove unused code * Updated Selection options * Refactor/pinia (#235) * Refactored store/interactions to Pinia * Disabled Vuex-persist plugin * Added PInia to Nuxt 2 * WIP refactored Panzoom.vue to <setup> Composition API * Refactored store/artboards to TS & Pinia * Refactored store/dev to TS & Pinia * Refactored store/focusMode in TS and Pinia * Refactored gui, history, hoverArtboard, interactions, selectedArtboards to TS & Pinia * Added @pinia-plugin-persistedstate for Pinia persisted state * Fixes and improvements to stores * Changed rightClickMenu to TS and use Pinia stores * Added Pinia store to FocusArtboard * Fixed incorrect function calls and use getCurrentInstance.proxy for Panzoom.vue * Refactored PanzoomControls in TS and use Pinia store * Refactored Artboards w/ Pinia, TS, <script setup> * Refactored Artboard w/ <script setup>, TS, Pinia * Refactored screenshot w/ Pinia, TS, <script setup> * Added pinia to artboardeditable * Refactored SidePanel to TS, Pinia, script setup * Refactored ToolBar to TS, script setup, Pinia * Refactored URLInput to TS and Pinia * Migrated more calls to Pinia and fixed wrong variable usage * Removed data prop from artboardEditable and added TS * Added Pinia types * Replaced "state" with "this" (Pinia fix) * More Pinia app usage updates * Updated nuxt types, vueuse, vue (2.7->2.7.14) * Added local TypeScript version to avoid VSCode Volar plugin failing * Changed nuxt "env" to "publicRuntimeConfig" * Added lodash types * Refactored Panzoom.vue, but having race conditions for the mouse/keyboard events * Fixed reference to prop in artboard.vue * Refactored Artboards.vue * Tidied up nuxt.config * Updated yarn lock * Added DevModeHud to see app state in dev mode * Added DevListeners.vue to show all EventListeners in the app * Added canDragSelect event to useEventHandler * Minor improvements to store/artboards.ts * Fixed bug in store/dev * Replaced WebPage.vue's Vuex calls with Pinia * Fixed mapState config for URLInput.vue * Migrated artboardEditable's Vuex call to Pinia * Simplified index.vue * Finished DevListeners, which is able to get all the event listeners and when user hovers over the list, they are highlighted in the DOM * Re-added pinia-plugin-persistedstate-2, which works with Nuxt 2 for persisted store state * Fixed reference to prop that was a string but should have been a data ref * Refactored last Vuex calls to Pinia * Fixed toggleGui() in store/gui * Fixed reactivity bug w/ Pinia in store/artboards using Vue.set() instead of just replacing object inside of array * Fixed double "this.this" reference in store/history * Removed unused SyncButton * Fixed ability to scroll across multiple WebPages * Added missing computed() around imported Store variables in <Artboards> * Fixed isHover from a function to a computed value <Arboard> * Improved resizing interaction and styling of <Artboard> during hover and when selected * Replaced Pinia $subscribe() with $onAction, which is more like Vuex's $subscribe * Changed remaining .commit() in WebPage to use Pinia * Refactored enableSelections and createSelectionInstance * Fixed @keyup assignment from 2 comma-separated functions into just one function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.