Skip to content

Fix duplication of features on first load #5742

Merged
fregante merged 1 commit intomainfrom
brand-new-ajax-with-50%-less-runs
Jun 29, 2022
Merged

Fix duplication of features on first load #5742
fregante merged 1 commit intomainfrom
brand-new-ajax-with-50%-less-runs

Conversation

@fregante
Copy link
Copy Markdown
Member

@fregante fregante commented Jun 29, 2022

Here's the sequence again:

Screen Shot

Generated via

['turbo:before-cache',
'turbo:before-fetch-request',
'turbo:before-fetch-response',
'turbo:before-render',
'turbo:before-stream-render',
'turbo:before-visit',
'turbo:click',
'turbo:frame-load',
'turbo:frame-render',
'turbo:load',
'turbo:reload',
'turbo:render',
'turbo:submit-end',
'turbo:submit-start',
'turbo:visit',
'pjax:start',
'pjax:end',
'pjax:complete',
'pjax:error',].map(x => document.addEventListener(x, e => console.log(x)))

@fregante fregante changed the title Use turbo:render for ajaxed events Fix duplication of features Jun 29, 2022
@fregante fregante marked this pull request as ready for review June 29, 2022 04:50
@fregante fregante merged commit 10d5754 into main Jun 29, 2022
@fregante fregante deleted the brand-new-ajax-with-50%-less-runs branch June 29, 2022 05:29
@fregante fregante changed the title Fix duplication of features Fix duplication of features on first load Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Some HTML elements get inserted twice

2 participants