Merged
Conversation
jtoar
commented
Jan 23, 2024
Comment on lines
-22
to
-26
| "jest": { | ||
| "testPathIgnorePatterns": [ | ||
| "/dist/" | ||
| ] | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
I removed these Jest related config options here and in a few other places in the spirit of cleaning up because they weren't being used
jtoar
commented
Jan 23, 2024
Contributor
Author
There was a problem hiding this comment.
This wasn't being used; this package wasn't built by babel nor was it using Jest. I did this everywhere else I could
Tobbe
approved these changes
Jan 24, 2024
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jan 25, 2024
…dleware * 'main' of github.com:redwoodjs/redwood: chore(structure): switch to vitest (redwoodjs#9878) chore(cli): switch to vitest (redwoodjs#9863) feat(dbAuth): Refactor dbAuthHandler to support WebAPI Request events (redwoodjs#9835) fix(crwa): remove yarn-install option for yarn 1 (redwoodjs#9881) chore(esbuild): dedupe esbuild config (redwoodjs#9875) chore(esm): convert `@redwoodjs/cli-helpers` to ESM (redwoodjs#9872) fix(studio): Add version checks when first running Studio (redwoodjs#9876)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up duplicated esbuild config.
Any package using esbuild to build can import
buildfrombuildDefaults.mjsin the root of the framework and call it which should more often than not just work. It builds all source files the way babel currently does. It doesn't do any bundling or polyfilling or anything fancy by default. It can take a few options though to do fancy things. See these examples here for packages that are bundled and have dual exports:The goal here was to start cleaning up tech debt and duplicated code before it gets out of hand. I'm sure more patterns will arise or better ways of doing this as we migrate more packages away from Babel and to ESM.
I tested by checking in the dist from main by removing the
distline in the.gitignoreand compared all of the changes against that.