Skip to content

9316/update mantine setup#9388

Merged
dac09 merged 6 commits intoredwoodjs:mainfrom
bnn1:9316/update-mantine-setup
Nov 27, 2023
Merged

9316/update mantine setup#9388
dac09 merged 6 commits intoredwoodjs:mainfrom
bnn1:9316/update-mantine-setup

Conversation

@bnn1
Copy link
Contributor

@bnn1 bnn1 commented Nov 7, 2023

Include mantine css and postcss files during mantine setup

There's a bit overlap with #9309 PR: both PRs change the same file - storybook mantine template.

Fixes #9316

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnn1! Just got around to reviewing this one. I ran it and it worked locally. Still need to read mantine's docs so I have context, but I noticed a few things so pointing those out for now:

@bnn1 bnn1 requested a review from jtoar November 16, 2023 11:37
@bnn1
Copy link
Contributor Author

bnn1 commented Nov 23, 2023

Hey @jtoar, I've made requested changes

@dac09 dac09 added this to the next-release milestone Nov 27, 2023
@dac09 dac09 added the release:fix This PR is a fix label Nov 27, 2023
@dac09 dac09 added the fixture-ok Override the test project fixture check label Nov 27, 2023
Copy link
Contributor

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @bnn1!

Taking over from @jtoar here. Everything looking good!

I've noticed the docs for Redwood setup on the mantine website is out of date though! (Since v6 we no longer use webpack by default).

@dac09 dac09 enabled auto-merge (squash) November 27, 2023 07:37
@dac09 dac09 assigned dac09 and unassigned jtoar Nov 27, 2023
@dac09 dac09 merged commit 1f04ce7 into redwoodjs:main Nov 27, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: next-release-patch, v6.4.1 Nov 29, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: v6.4.1, next-release-patch Nov 29, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
dac09 added a commit that referenced this pull request Jan 22, 2024
…nario-multiple-tests

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (#9598)
  fix(deps): update storybook monorepo to v7.6.2 (#9597)
  RSC: Generate a route manifest (#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (#9575)
  add documentation on mocking useParams in component test (#9284)
  Update Typescript to 5.3.2 (#9589)
  RSC: Refactor build process (#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (#9579)
  fix: Prevent `rw graphiql setup` from breaking with encryptSession error (#9582)
  fix: Remove "god code" typos from auth READMEs (#9583)
  Experimental Dockerfile: Fix typo in setup command (#9577)
  fix(streaming-ssr): Fixes running the streaming server using rw serve (#9558)
  9316/update mantine setup (#9388)
  chore: clean up `RouteParams` type test structure (#9573)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixture-ok Override the test project fixture check release:fix This PR is a fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: Mantine setup yarn rw setup ui mantine is not updated to work with Mantine V7

3 participants