Use Prettier#1071
Merged
timdorr merged 3 commits intoreduxjs:masterfrom Nov 6, 2018
NMinhNguyen:prettier
Merged
Conversation
|
Deploy preview for react-redux-docs ready! Built with commit 1849851 |
NMinhNguyen
commented
Nov 4, 2018
Member
|
OK, resolved the conflicts and updated the code. Thanks! |
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* Use Prettier * Make sure linting and formatting are part of the testing process. * Run prettier on existing code.
This was referenced Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw @timdorr's suggestion to use Prettier in #1065 (comment) and decided to take a stab at integrating it. Given this project is already using ESLint, I thought running Prettier via ESLint was the simplest option (it does however mean that only linted files are run through Prettier, i.e.
src,test/utilsandtest/components), but I'm happy to change the approach.