auto-docs: Update Go modules #336
Conversation
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughUpdated blobl-editor/wasm/go.mod to bump github.com/redpanda-data/benthos/v4 from v4.55.0 to v4.56.0 and github.com/redpanda-data/connect/v4 from v4.62.0 to v4.63.0. Added new indirect dependencies: bufbuild/reflect/connectrpc/go, bufbuild/reflect/protocolbuffers/go, connectrpc.com/connect, bufbuild/prototransform, and github.com/pkg/errors. No source code changes beyond go.mod are indicated. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
blobl-editor/wasm/go.mod (2)
29-29: prototransform added indirectly—watch for code size and TinyGo quirks.bufbuild/prototransform can pull in reflection/protobuf helpers; ensure they don’t bloat the WASM artifact or hit TinyGo limitations. If size regresses, consider pruning via build tags or replacing reflect-heavy paths.
73-73: github.com/pkg/errors added indirectly—OK, just noting.No action needed; upstream still uses it. Prefer std lib errors in direct code when possible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
blobl-editor/wasm/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
blobl-editor/wasm/go.mod(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Redirect rules - docs-ui
- GitHub Check: Header rules - docs-ui
- GitHub Check: Pages changed - docs-ui
- GitHub Check: test-bloblang-playground
- GitHub Check: build
🔇 Additional comments (3)
blobl-editor/wasm/go.mod (3)
8-9: Deps bump LGTM; double-check WASM build still passes.The Benthos (v4.56.0) and Connect (v4.63.0) bumps look fine for a module-only PR. Please confirm the Bloblang playground WASM build remains green in CI and that no transitive changes increase the WASM payload size unexpectedly.
13-15: New ConnectRPC-related indirects—verify license/size impact in WASM.These come via upstream; likely harmless, but please sanity‑check:
- License compatibility for docs-site distribution.
- Whether tree‑shaking eliminates them from the final .wasm.
3-5: Confirm go directive format; patch version may be invalid here.The
godirective typically uses major.minor (e.g.,go 1.24), whiletoolchaincarries the patch (e.g.,go1.24.2). Ifgo 1.24.1is rejected by your toolchain, switch togo 1.24.Apply if needed:
-go 1.24.1 +go 1.24
23105fb to
9856c36
Compare
9856c36 to
4a01b46
Compare
4a01b46 to
af29ee3
Compare
This PR updates the Go modules for the Bloblang playground Wasm code.