auto-docs: Update Go modules #314
Conversation
✅ Deploy Preview for docs-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe Possibly related PRs
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
blobl-editor/wasm/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
blobl-editor/wasm/go.mod(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - docs-ui
- GitHub Check: Header rules - docs-ui
- GitHub Check: Pages changed - docs-ui
- GitHub Check: build
blobl-editor/wasm/go.mod
Outdated
| github.com/redpanda-data/benthos/v4 v4.53.1 | ||
| github.com/redpanda-data/connect/v4 v4.60.1 |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Remember to tidy & compile-test after version bumps
All bumped modules (benthos, connect, cuelang, urfave/cli, OTel core) are minor/patch upgrades, so no red flags.
Still, to avoid subtle breakages and stale go.sum entries, please:
- Run
go mod tidyand commit the refreshedgo.sum. - Re-build the Wasm target (
make wasmor your usual script) to catch any API changes early. - Double-check CI is pinned to Go 1.24.2 (the toolchain line) so the new deps build identically locally and in CI.
Let me know if you hit any incompatibilities—happy to help track them down.
Also applies to: 13-13, 80-80, 91-93
🏁 Script executed:
#!/usr/bin/env bash
# Quickly verify that the module graph is clean and the project compiles
set -euo pipefail
go mod tidy
git diff --exit-code go.sum # Fails if go.sum changed
go vet ./...
go test ./... # or `make wasm` if tests aren't availableLength of output: 228
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Navigate to the module directory before running Go commands
cd blobl-editor/wasm
# Verify module graph is clean and project compiles
go mod tidy
git diff --exit-code go.sum
go vet ./...
go test ./...Length of output: 7383
Update verification script for Wasm build constraints
The existing go vet ./... step fails on the host because syscall/js is only available under GOOS=js GOARCH=wasm. After bumping the Wasm module’s dependencies, please:
- cd into the Wasm module before running Go commands
- Run
go mod tidyand commit any changes togo.sum - Build and vet the Wasm target under the correct environment (or use your existing
make wasmrule) - Confirm CI is still pinned to Go 1.24.2
Updated verification snippet:
#!/usr/bin/env bash
set -euo pipefail
# 1. Verify module graph
cd blobl-editor/wasm
go mod tidy
git diff --exit-code go.sum
# 2. Build the Wasm target
make wasm
# 3. Vet (and optionally test) under the Wasm environment
GOOS=js GOARCH=wasm go vet ./...
# If you have Wasm-specific tests:
# GOOS=js GOARCH=wasm go test ./...🤖 Prompt for AI Agents
In blobl-editor/wasm/go.mod around lines 8 to 9, the verification script for the
Wasm build needs updating because running `go vet ./...` on the host fails due
to `syscall/js` being available only under the Wasm environment. To fix this,
update the verification process to first change directory into the Wasm module,
run `go mod tidy` and commit any changes to `go.sum`, then build the Wasm target
using the existing `make wasm` rule, and finally run `go vet` with the
environment variables `GOOS=js GOARCH=wasm` set to properly vet the Wasm code.
Also ensure the CI remains pinned to Go 1.24.2.
adaa69a to
28caa28
Compare
This PR updates the Go modules for the Bloblang playground Wasm code.