Skip to content

Conversation

@guybe7
Copy link
Collaborator

@guybe7 guybe7 commented Dec 16, 2021

Sort the sub-commands so that every time we execute the script it generates the exact same results.
This will case less merge conflicts if two PRs edit different json files.

also:

  • make the script agnostic to where it is executed (more flexible).
  • add documentation about commands.c and the json files in the readme.

@oranagra oranagra merged commit ffbe36f into redis:unstable Dec 16, 2021
hwware pushed a commit to hwware/redis that referenced this pull request Dec 20, 2021
Sort the sub-commands so that every time we execute the script it generates the exact same results.
This will case less merge conflicts if two PRs edit different json files.

also:
* make the script agnostic to where it is executed (more flexible).
* add documentation about commands.c and the json files in the readme.

Co-authored-by: Oran Agra <oran@redislabs.com>
yossigo pushed a commit that referenced this pull request Jan 6, 2022
With this rule, the script to generate commands.c from JSON runs whenever commands.o is built if any of commands/*.json are modified. Without such rule, it's easy to forget to run the script when updating the JSON files.

It's a follow-up on #9656 and #9951.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants