Add FUNCTION FLUSH command to flush all functions #9936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new FUNCTION sub-command allows delete all the functions. An optional [SYNC|ASYNC] argument can be given to control whether or not to flush the function synchronously or asynchronously. if not given the default flush mode is chosen by lazyfree-lazy-user-flush configuration values.
oranagra
reviewed
Dec 13, 2021
Member
|
@redis/core-team please approve another small step in the functions project. |
zuiderkwast
reviewed
Dec 13, 2021
Contributor
zuiderkwast
left a comment
There was a problem hiding this comment.
Looks good. Didn't review the tests.
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
madolson
approved these changes
Dec 13, 2021
Contributor
madolson
left a comment
There was a problem hiding this comment.
Approving the API, and a minor wording note.
oranagra
reviewed
Dec 14, 2021
added 2 commits
December 15, 2021 18:58
Use `server.dirty++` instead of `forceCommandPropagation` to make sure the command will be counted as changing the data (for persistence configuration).
Use `addReplySubcommandSyntaxError` on `FUNCTION FLUSH`
added 3 commits
December 15, 2021 19:58
unit/functions was missing from test_helper.tcl which caused functions tests not to run when not directly specify. Also, added `function flush` to server.tcl to make sure functions will be cleaned between tests on external server.
sundb
reviewed
Dec 16, 2021
Co-authored-by: sundb <sundbcn@gmail.com>
oranagra
reviewed
Dec 16, 2021
yossigo
approved these changes
Dec 16, 2021
Merged
3 tasks
oranagra
approved these changes
Dec 16, 2021
hwware
pushed a commit
to hwware/redis
that referenced
this pull request
Dec 20, 2021
Added `FUNCTION FLUSH` command. The new sub-command allows delete all the functions. An optional `[SYNC|ASYNC]` argument can be given to control whether or not to flush the functions synchronously or asynchronously. if not given the default flush mode is chosen by `lazyfree-lazy-user-flush` configuration values. Add the missing `functions.tcl` test to the list of tests that are executed in test_helper.tcl, and call FUNCTION FLUSH in between servers in external mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on conversion on #9923, added
FUNCTION FLUSHcommand. The new sub-command allows delete all the functions. An optional[SYNC|ASYNC]argument can be given to control whether or not to flush the functions synchronously or asynchronously. if not given the default flush mode is chosen bylazyfree-lazy-user-flushconfiguration values.Add the missing
functions.tcltest to the list of tests that are executed in test_helper.tcl, and call FUNCTION FLUSH in between servers in external mode