Client eviction ci issues #9549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve timing issue of test taking more than 1sec and therefore failing on slow CI platforms.
Because signal hack doesn't force all sent commands to be handled before sleep when using TLS. Added tls skip mechanism to test framework.
If client was freed in processCommand we need to propagate the error out put processInputBuffer so we know not to access the client struct anymore (in beforeNextClient).
Member
|
triggered Daily CI https://github.com/redis/redis/actions/runs/1272909856 |
oranagra
reviewed
Sep 25, 2021
Attempt to fix rare test failure with TLS.
Added `debug pause-cron [0|1]` command and use it to disable cron based client eviction during test.
Member
|
partial daily CI triggered: https://github.com/redis/redis/actions/runs/1275199158 |
oranagra
approved these changes
Sep 26, 2021
Member
|
@yoav-steinberg it seems that there are still some sporadic issues: https://github.com/redis/redis/runs/3726678420?check_suite_focus=true |
madolson
added a commit
to madolson/redis
that referenced
this pull request
Feb 21, 2023
oranagra
pushed a commit
that referenced
this pull request
Feb 28, 2023
warrick1016
pushed a commit
to ctripcorp/Redis-On-Rocks
that referenced
this pull request
Sep 2, 2025
Fixing CI test issues introduced in redis#8687 - valgrind warnings in readQueryFromClient when client was freed by processInputBuffer - adding DEBUG pause-cron for tests not to be time dependent. - skipping a test that depends on socket buffers / events not compatible with TLS - making sure client got subscribed by not using deferring client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing CI test issues introduced in #8687
DEBUG pause-cron [1|0]for tests not to be time dependent.