Skip to content

CLIENT LIST / INFO show resp version #9508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oranagra merged 1 commit into from
Sep 19, 2021
Merged

CLIENT LIST / INFO show resp version #9508

oranagra merged 1 commit into from
Sep 19, 2021

Conversation

@hwware
Copy link
Contributor

@hwware hwware commented Sep 15, 2021

image

@hwware hwware requested review from oranagra and yossigo September 15, 2021 20:33
@madolson madolson added state:major-decision Requires core team consensus approval-needed Waiting for core team approval to be merged labels Sep 15, 2021
@oranagra oranagra added state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten release-notes indication that this issue needs to be mentioned in the release notes labels Sep 16, 2021
@oranagra oranagra changed the title Client List command show resp version CLIENT LIST / INFO show resp version Sep 19, 2021
@oranagra oranagra merged commit 7c37639 into redis:unstable Sep 19, 2021
enjoy-binbin added a commit to enjoy-binbin/redis-doc that referenced this pull request Jan 12, 2022
@enjoy-binbin
Add multi-mem and resp in CLIENT LIST
20f839d 
multi-mem: added in redis/redis#8687
resp: added in redis/redis#9508

Also adjust the order of fields to better match the output

The current output format is (redis unstable branch):
```
id=3 addr=127.0.0.1:50188 laddr=127.0.0.1:6379 fd=8 name= age=7 idle=0
flags=N db=0 sub=0 psub=0 multi=-1 qbuf=26 qbuf-free=20448 argv-mem=10
multi-mem=0 obl=0 oll=0 omem=0 tot-mem=40986 events=r cmd=client|list
user=default redir=-1 resp=2
```
@enjoy-binbin enjoy-binbin mentioned this pull request Jan 12, 2022
Merged
itamarhaber pushed a commit to redis/redis-doc that referenced this pull request Jan 23, 2022
@enjoy-binbin
Add multi-mem and resp in CLIENT LIST (#1740)
cc0427b 
multi-mem: added in redis/redis#8687
resp: added in redis/redis#9508

Also adjust the order of fields to better match the output

The current output format is (redis unstable branch):
```
id=3 addr=127.0.0.1:50188 laddr=127.0.0.1:6379 fd=8 name= age=7 idle=0
flags=N db=0 sub=0 psub=0 multi=-1 qbuf=26 qbuf-free=20448 argv-mem=10
multi-mem=0 obl=0 oll=0 omem=0 tot-mem=40986 events=r cmd=client|list
user=default redir=-1 resp=2
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yossigo yossigo yossigo approved these changes

@oranagra oranagra oranagra approved these changes

+2 more reviewers

@soloestoy soloestoy soloestoy approved these changes

@madolson madolson madolson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approval-needed Waiting for core team approval to be merged release-notes indication that this issue needs to be mentioned in the release notes state:major-decision Requires core team consensus state:to-be-merged The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hwware @yossigo @oranagra @soloestoy @madolson