Make Cluster-bus port configurable with new cluster-port config #9389

hwware · 2021-08-18T13:55:47Z

Background:
Currently, for a cluster node, cluster bus port = command port+ 10000, which is a fixed value.

We would like to make the value flexible, thus user could have more choice for the offset between command port
and cluster bus port.

The parameter "cluster-port" can be added in redis.conf, the value could be from 1 to 65535.

Example for 4 node config files in a clsuter:

node1:

port 6381
cluster-enabled yes
cluster-config-file nodes1-6381.conf
cluster-node-timeout 15000
cluster-port 10000

node2:

port 6382
cluster-enabled yes
cluster-config-file nodes2-6382.conf
cluster-node-timeout 15000
cluster-port 10001

node3:

port 6383
cluster-enabled yes
cluster-config-file nodes3-6383.conf
cluster-node-timeout 15000
cluster-port 20000

node4:

port 6384
cluster-enabled yes
cluster-config-file nodes4-6384.conf
cluster-node-timeout 15000

the result:

redis.conf

hwware · 2021-09-23T14:43:19Z

@madolson I update the codes for the requirement: make the cluster port more flexible, instead of using a fixed value: command port+ 10000. Please take a look, Thanks

madolson

Implementation is good, just some style comments

redis.conf

src/cluster.c

src/cluster.h

src/server.h

src/cluster.c

redis.conf

madolson

I suppose we should update the https://redis.io/commands/cluster-meet documentation in parallel. I realized that it was wrong.

madolson · 2021-09-30T05:20:36Z

@redis/core-team Approval for the new config name

hwware · 2021-09-30T13:54:15Z

I suppose we should update the https://redis.io/commands/cluster-meet documentation in parallel. I realized that it was wrong.

I will update the documentation with more details after this PR is merged. Thanks for your words.

redis.conf

madolson

LGTM

oranagra

LGTM. maybe we wanna add some basic test coverage?

Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>

In redis#9389, we add a new cluster-port config and make cluster bus port configurable. Now add support for this parameter in redis-cli. Mainly for `--cluster create` and `--cluster add-node`, we can use `ip:port@bus_port` to pass the `cluster-port` parameter. The bus_port is optional, if not specified it is the same as before. Also add the `bus_port` field in `--cluster backup`, we also need to backup the `cluster-port`. Fixes redis#10342

In `CLUSTER MEET`, bus-port argument was added in 11436b1. For cluster announce ip / port implementation, part of the 4.0-RC1. And in redis#9389, we add a new cluster-port config and make cluster bus port configurable, part of the 7.0-RC1.

In `CLUSTER MEET`, bus-port argument was added in 11436b1. For cluster announce ip / port implementation, part of the 4.0-RC1. And in #9389, we add a new cluster-port config and make cluster bus port configurable, part of the 7.0-RC1.

In #9389, we add a new `cluster-port` config and make cluster bus port configurable, and currently redis-cli --cluster create/add-node doesn't support with a configurable `cluster-port` instance. Because redis-cli uses the old way (port + 10000) to send the `CLUSTER MEET` command. Now we add this support on redis-cli `--cluster`, note we don't need to explicitly pass in the `cluster-port` parameter, we can get the real `cluster-port` of the node in `clusterManagerNodeLoadInfo`, so the `--cluster create` and `--cluster add-node` interfaces have not changed. We will use the `cluster-port` when we are doing `CLUSTER MEET`, also note that `CLUSTER MEET` bus-port parameter was added in 4.0, so if the bus_port (the one in redis-cli) is 0, or equal (port + 10000), we just call `CLUSTER MEET` with 2 arguments, using the old form. Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>

In `CLUSTER MEET`, bus-port argument was added in 11436b1. For cluster announce ip / port implementation, part of the 4.0-RC1. And in redis#9389, we add a new cluster-port config and make cluster bus port configurable, part of the 7.0-RC1.

In redis#9389, we add a new `cluster-port` config and make cluster bus port configurable, and currently redis-cli --cluster create/add-node doesn't support with a configurable `cluster-port` instance. Because redis-cli uses the old way (port + 10000) to send the `CLUSTER MEET` command. Now we add this support on redis-cli `--cluster`, note we don't need to explicitly pass in the `cluster-port` parameter, we can get the real `cluster-port` of the node in `clusterManagerNodeLoadInfo`, so the `--cluster create` and `--cluster add-node` interfaces have not changed. We will use the `cluster-port` when we are doing `CLUSTER MEET`, also note that `CLUSTER MEET` bus-port parameter was added in 4.0, so if the bus_port (the one in redis-cli) is 0, or equal (port + 10000), we just call `CLUSTER MEET` with 2 arguments, using the old form. Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>

hwware requested review from oranagra and yossigo August 18, 2021 15:21

madolson reviewed Aug 18, 2021

View reviewed changes

redis.conf Outdated Show resolved Hide resolved

hwware mentioned this pull request Sep 7, 2021

Make cluster-port variable configurable hwware/redis#20

Open

hwware changed the title ~~Make cluster-port-incr variable configurable, the default value is 10000~~ Add cluster-port parameter in the redis.conf Sep 23, 2021

madolson reviewed Sep 25, 2021

View reviewed changes

redis.conf Outdated Show resolved Hide resolved

src/cluster.c Outdated Show resolved Hide resolved

src/cluster.h Outdated Show resolved Hide resolved

src/server.h Outdated Show resolved Hide resolved

src/cluster.c Outdated Show resolved Hide resolved

madolson reviewed Sep 30, 2021

View reviewed changes

redis.conf Outdated Show resolved Hide resolved

madolson reviewed Sep 30, 2021

View reviewed changes

madolson added approval-needed Waiting for core team approval to be merged state:major-decision Requires core team consensus labels Sep 30, 2021

YaacovHazan requested changes Sep 30, 2021

View reviewed changes

redis.conf Outdated Show resolved Hide resolved

madolson approved these changes Oct 3, 2021

View reviewed changes

itamarhaber approved these changes Oct 6, 2021

View reviewed changes

oranagra approved these changes Oct 6, 2021

View reviewed changes

hwware and others added 8 commits October 12, 2021 16:52

Add cluster-port-incr config parameter

23f8418

update redis.conf comment typo

3efdac7

update to cluster-port as a parameter

8d3cb8c

remove 3th parameter

b3039cc

remove comments

06eb07a

Addressing the comments

9568953

Update redis.conf

a6facb2

Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>

Removed double you to

6cc7bea

hwware force-pushed the cluster_port_incr_config branch from b8f5cd8 to 6cc7bea Compare October 12, 2021 21:25

yossigo approved these changes Oct 17, 2021

View reviewed changes

madolson removed the approval-needed Waiting for core team approval to be merged label Oct 18, 2021

madolson changed the title ~~Add cluster-port parameter in the redis.conf~~ Make Cluster-bus port configurable with new cluster-port config Oct 18, 2021

madolson merged commit 1c2b5f5 into redis:unstable Oct 19, 2021

oranagra added the release-notes indication that this issue needs to be mentioned in the release notes label Oct 19, 2021

oranagra mentioned this pull request Feb 25, 2022

redis-cli --cluster create , failing to create cluster. #10342

Closed

enjoy-binbin mentioned this pull request Feb 25, 2022

Add cluster-port support to redis-cli --cluster #10344

Merged

enjoy-binbin mentioned this pull request Feb 27, 2022

Add bus_port argument in cluster-meet.json #10304

Merged

enjoy-binbin mentioned this pull request Jul 8, 2022

Redis cluster bus port #10954

Closed

enjoy-binbin mentioned this pull request Feb 15, 2024

Add cluster-bus-port option to allow the user set the port used to listen for cluster bus #4415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make Cluster-bus port configurable with new cluster-port config #9389

Make Cluster-bus port configurable with new cluster-port config #9389

Uh oh!

hwware commented Aug 18, 2021 •

edited

Loading

Uh oh!

Uh oh!

hwware commented Sep 23, 2021

Uh oh!

madolson left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madolson left a comment

Uh oh!

madolson commented Sep 30, 2021

Uh oh!

hwware commented Sep 30, 2021

Uh oh!

Uh oh!

madolson left a comment

Uh oh!

oranagra left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Make Cluster-bus port configurable with new cluster-port config #9389

Make Cluster-bus port configurable with new cluster-port config #9389

Uh oh!

Conversation

hwware commented Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hwware commented Sep 23, 2021

Uh oh!

madolson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madolson left a comment

Choose a reason for hiding this comment

Uh oh!

madolson commented Sep 30, 2021

Uh oh!

hwware commented Sep 30, 2021

Uh oh!

Uh oh!

madolson left a comment

Choose a reason for hiding this comment

Uh oh!

oranagra left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hwware commented Aug 18, 2021 •

edited

Loading