Fix a few typos and improve grammar of redis.conf#928
Merged
antirez merged 1 commit intoredis:unstablefrom Feb 4, 2013
Merged
Conversation
Make several edits to the example redis.conf configuration file for improved flow and grammar. Signed-off-by: David Celis <me@davidcel.is>
|
Thanks for your time! |
antirez
added a commit
that referenced
this pull request
Feb 4, 2013
Fix a few typos and improve grammar of redis.conf
Contributor
|
Merged, thanks! |
sundb
pushed a commit
to sundb/redis
that referenced
this pull request
Jul 28, 2025
…USTER SETSLOT (redis#928) This fixes redis#899. In that issue, the primary is cluster-allow-replica-migration no and its replica is cluster-allow-replica-migration yes. And during the slot migration: 1. Primary calling blockClientForReplicaAck, waiting its replica. 2. Its replica reconfiguring itself as a replica of other shards due to replica migration and disconnect from the old primary. 3. The old primary never got the chance to receive the ack, so it got a timeout and got a NOREPLICAS error. In this case, the replicas might automatically migrate to another primary, resulting in the client being unblocked with the NOREPLICAS error. In this case, since the configuration will eventually propagate itself, we can safely ignore this error on the source node. Signed-off-by: Binbin <binloveplay1314@qq.com>
minchopaskal
pushed a commit
to minchopaskal/redis
that referenced
this pull request
Oct 16, 2025
…actions/checkout-4.1.2 build(deps): bump actions/checkout from 4.1.1 to 4.1.2
Closed
gabsow
added a commit
to gabsow/redis
that referenced
this pull request
Nov 30, 2025
This update includes the following fixes: **Bug fixes** - redis#945 Bloom filter: crash when loading an invalid RDB file (MOD-11590, VDP-2707) - redis#936 Cuckoo filter: crash when loading an invalid RDB file (MOD-11593, VDP-2708) - redis#928 Bloom filter: memory leak when restoring an invalid RDB file (MOD-12225)
gabsow
added a commit
to gabsow/redis
that referenced
this pull request
Nov 30, 2025
This update includes the following fixes: **Bug fixes** - redis#945 Bloom filter: crash when loading an invalid RDB file (MOD-11590, VDP-2707) - redis#936 Cuckoo filter: crash when loading an invalid RDB file (MOD-11593, VDP-2708) - redis#928 Bloom filter: memory leak when restoring an invalid RDB file (MOD-12225)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make several edits to the example redis.conf configuration file for
improved flow and grammar.
Signed-off-by: David Celis me@davidcel.is