Tests: add a way to read raw RESP protocol reponses #9193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to distinguish between null response and an empty array (currently the tests infra translates both to an empty string/list)
enjoy-binbin
approved these changes
Jul 4, 2021
Member
Author
|
side note: i used to hate TCL...i still do.. |
madolson
approved these changes
Jul 4, 2021
Contributor
madolson
left a comment
There was a problem hiding this comment.
TCL is a pretty good language for writing tests, but I will always hate it though because it caused Redis to have a bizarre type system. All integers are strings but not all strings are integers, sure, makes sense.
> incr foo
(integer) 1
> append foo hi
3
> get foo
"1hi"
Contributor
|
@madolson yeah.. you don't even need append ([Edited] Append returns |
oranagra
added a commit
that referenced
this pull request
Jul 21, 2021
oranagra
added a commit
that referenced
this pull request
Jul 21, 2021
This makes it possible to distinguish between null response and an empty array (currently the tests infra translates both to an empty string/list) (cherry picked from commit 7103367)
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Sep 8, 2021
This makes it possible to distinguish between null response and an empty array (currently the tests infra translates both to an empty string/list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to distinguish between null response and an empty
array (currently the tests infra translates both to an empty string/list)