Check cluster_enabled in readwriteCommand just like readonlyCommand.#9015
Merged
Conversation
huangzhw
reviewed
May 31, 2021
madolson
approved these changes
Jun 21, 2021
madolson
left a comment
Contributor
There was a problem hiding this comment.
Doesn't seem like a major change to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that readwrite can only be used in cluster mode. So i add a check just like readonly command. Just a cleanup that consistent check
rewrite doc: https://redis.io/commands/readwrite