GEOSEARCH bybox bug fixes and new fuzzy tester#8445
Merged
oranagra merged 1 commit intoFeb 4, 2021
Conversation
Contributor
Author
|
@oranagra Thank you for the improvement of the original PR #8375, especially the algorithm that has a flash of light, I have actually put it in this PR. Note:
|
oranagra
reviewed
Feb 4, 2021
oranagra
reviewed
Feb 4, 2021
oranagra
reviewed
Feb 4, 2021
oranagra
reviewed
Feb 4, 2021
- New GEOSEARCH point in rectangle algorithm - Fix GEOSEARCH bybox width and height mismatch - Add GEOSEARCH bybox testing to the existing "GEOADD + GEORANGE randomized test" - Fix errors of GEOSEARCH bybox search due to projection of the box to a trapezoid (when the meter box is converted to long / lat it's no longer a box). - Add new fuzzy test to stress test the bybox corners and edges - Add some tests for edge cases of the bybox algorithm
Contributor
Author
|
updated, please review again, thanks @oranagra |
oranagra
approved these changes
Feb 4, 2021
Merged
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Mar 2, 2021
Fix errors of GEOSEARCH bybox search due to: 1. projection of the box to a trapezoid (when the meter box is converted to long / lat it's no longer a box). 2. width and height mismatch Changes: - New GEOSEARCH point in rectangle algorithm - Fix GEOSEARCH bybox width and height mismatch bug - Add GEOSEARCH bybox testing to the existing "GEOADD + GEORANGE randomized test" - Add new fuzzy test to stress test the bybox corners and edges - Add some tests for edge cases of the bybox algorithm Co-authored-by: Oran Agra <oran@redislabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix errors of GEOSEARCH bybox search due to:
Changes: