Add tests for RESP3 responce of ZINTER and ZRANGE #8391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was confusing as to why these don't return a map type. the reason is that order matters, so we need to make sure the client library knows to respect it. Added comments in the implementation and tests to cover it.
Member
Author
|
apparently the spec says: but that may be a controversial decision, see antirez/RESP3#30 regardless, for backwards compatibility with redis 6.0, we can't probably change the response type of ZRANGE in RESP3. @redis/core-team please share your thoughts. |
Collaborator
|
my vote to keeping the response as an array of tuples, it'll be weird if two commands that reply with elements from a zset would reply differently |
Collaborator
|
Agree with @guybe7 |
yossigo
approved these changes
Jan 25, 2021
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Mar 2, 2021
It was confusing as to why these don't return a map type. the reason is that order matters, so we need to make sure the client library knows to respect it. Added comments in the implementation and tests to cover it.
oranagra
added a commit
to redis/redis-specifications
that referenced
this pull request
Jan 5, 2023
see: * redis/redis#8391 * redis/redis#8504 Co-authored-by: Oran Agra <oran@redislabs.com>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was confusing as to why these don't return a map type.
the reason is that order matters, so we need to make sure the client
library knows to respect it.
Added comments in the implementation and tests to cover it.