Flow through the error handling path for most addReplyErrors #8226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9eedfd0 to
af056f1
Compare
oranagra
approved these changes
Dec 23, 2020
Member
oranagra
left a comment
There was a problem hiding this comment.
sorry, i'm behind on my notifications. didn't notice this one and suggested @filipecosta90 to do it in his PR.
This must be a separate commit, so i guess we can go ahead and merge it right away.
when you squash-merge this, please mention the other PR in the comment to show justification.
we now need to keep an eye for other pending PRs that add new commands (copied code from old ones), and tell everyone to adjust to this new thing.
p.s. i don't see any performance or memory degradation. am i missing something?
Contributor
Author
|
Just to circle back, I did double check the performance with benchmarks, and I couldn't find anything one way or the other. |
DebugNinjaSlayer
pushed a commit
to DebugNinjaSlayer/redis
that referenced
this pull request
Dec 27, 2020
Properly throw errors for invalid replication stream and support redis#8217
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Mar 2, 2021
Properly throw errors for invalid replication stream and support redis#8217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize most of the error calls so that they actually pass through the addReplyError* type commands. Although there are some fringe benefits, like reducing memory allocations, the main benefit is to catch errors thrown from the replica and detect replication divergence.