Adds path expansion to the config file parser.#803
Closed
proxypoke wants to merge 2 commits intoredis:unstablefrom
Closed
Adds path expansion to the config file parser.#803proxypoke wants to merge 2 commits intoredis:unstablefrom
proxypoke wants to merge 2 commits intoredis:unstablefrom
Conversation
added 2 commits
December 1, 2012 12:12
It's now possible to use ~ or environmental variables like $HOME in the config file (where appropriate).
yoav-steinberg
suggested changes
May 20, 2021
Contributor
There was a problem hiding this comment.
This looks decent.
I'd like feedback from more people too see if this feature makes sense. @yossigo?
Requires a rebase and handling of buffer size checks..
| break; | ||
| } | ||
| if (error == 0) { | ||
| strcpy(path, exp.we_wordv[0]); |
Contributor
There was a problem hiding this comment.
How do we know there's room in the destination?
Collaborator
|
@yoav-steinberg Do you see a lot of value in this?
|
Contributor
|
@yossigo You're right, |
Collaborator
|
@yoav-steinberg I agree |
Contributor
|
@proxypoke thanks. Although this is a nice Idea the PR it too limited and complicates |
sundb
pushed a commit
to sundb/redis
that referenced
this pull request
Jul 28, 2025
Primary side: Remove read handler upon RDB connection close. At this stage we do not expect any writed form that connection so it should be safe to remove the read handler. Otherwise the read handler will keep printing the `Client closed connection` logs, see handleReadResult. Signed-off-by: naglera <anagler123@gmail.com>
minchopaskal
pushed a commit
to minchopaskal/redis
that referenced
this pull request
Oct 16, 2025
XXH_ASSUME macro using `__builtin_assume` if supported (clang only fo…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's now possible to use ~ or environmental variables like $HOME in
the config file (where appropriate).