Add RESET command.#7982
Merged
Merged
Conversation
Perform full reset of all client connection states, is if the client was disconnected and re-connected. This affects: * MULTI state * Watched keys * MONITOR mode * Pub/Sub subscription * ACL/Authenticated state * Client tracking state The response is +RESET to make it easily distinguishable from other responses.
madolson
reviewed
Oct 28, 2020
| c->cmd->proc != execCommand && c->cmd->proc != discardCommand && | ||
| c->cmd->proc != multiCommand && c->cmd->proc != watchCommand) | ||
| c->cmd->proc != multiCommand && c->cmd->proc != watchCommand && | ||
| c->cmd->proc != resetCommand) |
Co-authored-by: Oran Agra <oran@redislabs.com>
oranagra
previously approved these changes
Nov 1, 2020
itamarhaber
reviewed
Nov 1, 2020
itamarhaber
left a comment
Member
There was a problem hiding this comment.
Please also review redis/redis-doc#1426
Member
|
Also, worth mentioning in the top comment what it does to RESP, dbnum, and client reply perhaps. |
Co-authored-by: Itamar Haber <itamar@redislabs.com>
itamarhaber
approved these changes
Nov 1, 2020
oranagra
approved these changes
Nov 1, 2020
madolson
approved these changes
Nov 2, 2020
JackieXie168
pushed a commit
to JackieXie168/redis
that referenced
this pull request
Nov 19, 2020
Perform full reset of all client connection states, is if the client was disconnected and re-connected. This affects: * MULTI state * Watched keys * MONITOR mode * Pub/Sub subscription * ACL/Authenticated state * Client tracking state * Cluster read-only/asking state * RESP version (reset to 2) * Selected database * CLIENT REPLY state The response is +RESET to make it easily distinguishable from other responses. Co-authored-by: Oran Agra <oran@redislabs.com> Co-authored-by: Itamar Haber <itamar@redislabs.com>
18 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform full reset of all client connection states, is if the client was
disconnected and re-connected. This affects:
MULTIstateMONITORmodeCLIENT REPLYstateThe response is +RESET to make it easily distinguishable from other
responses.
Resolves #5571