Skip to content

Fix RESP3 response for HKEYS/HVALS on non-existing key #7781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oranagra merged 1 commit into from
Sep 10, 2020
Merged

Fix RESP3 response for HKEYS/HVALS on non-existing key #7781

oranagra merged 1 commit into from
Sep 10, 2020

Conversation

@oranagra
Copy link
Member

@oranagra oranagra commented Sep 10, 2020

Fixes #7776

@oranagra
Copy link
Member Author

oranagra commented Sep 10, 2020

Test infrastructure doesn't yet support RESP3.
manual testing:

$ redis-cli
127.0.0.1:6379> HELLO 3
1# "server" => "redis"
2# "version" => "6.0.8"
3# "proto" => (integer) 3
4# "id" => (integer) 4
5# "mode" => "standalone"
6# "role" => "master"
7# "modules" => (empty array)
127.0.0.1:6379> HKEYS test_nonexistent_key
(empty array)
127.0.0.1:6379> quit
$ redis-cli
127.0.0.1:6379> HKEYS test_nonexistent_key
(empty array)

@oranagra oranagra merged commit de8d320 into redis:unstable Sep 10, 2020
@oranagra oranagra deleted the fix_resp3_hvals branch September 10, 2020 07:09
JackieXie168 pushed a commit to JackieXie168/redis that referenced this pull request Nov 4, 2020
@oranagra
Fix RESP3 response for HKEYS/HVALS on non-existing key (redis#7781)
1e74eb8
@enjoy-binbin enjoy-binbin mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamarhaber itamarhaber itamarhaber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HKEYS returns empty hash in RESP3 [BUG]

2 participants

@oranagra @itamarhaber