Replace some unnecessary calls to echo and cat in tests#461
Merged
Conversation
Tcl's exec can send data to stdout itself, no need to call cat/echo for that usually.
antirez
added a commit
that referenced
this pull request
Apr 23, 2012
Replace some unnecessary calls to echo and cat in tests
Contributor
|
Thank you, merged. |
sundb
referenced
this pull request
in sundb/redis
Jul 28, 2025
When there is a link failure while an ongoing MEET request is sent the sending node stops sending anymore MEET and starts sending PINGs. Since every node responds to PINGs from unknown nodes with a PONG, the receiving node never adds the sending node. But the sending node adds the receiving node when it sees a PONG. This can lead to asymmetry in cluster membership. This changes makes the sender keep sending MEET until it sees a PONG, avoiding the asymmetry. --------- Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
May 25, 2026
When there is a link failure while an ongoing MEET request is sent the sending node stops sending anymore MEET and starts sending PINGs. Since every node responds to PINGs from unknown nodes with a PONG, the receiving node never adds the sending node. But the sending node adds the receiving node when it sees a PONG. This can lead to asymmetry in cluster membership. This changes makes the sender keep sending MEET until it sees a PONG, avoiding the asymmetry. Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com> See valkey-io/valkey#461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tcl's exec can send data to stdout itself, no need to call cat/echo for that usually.
See also this message at stackoverflow: http://stackoverflow.com/questions/10188886/redis-error-when-running-tcl-helper-script-on-windows-7-32bit-edition
There are quite a few [exec cat $something] calls in the tests that could be replaced by simple open/read/close calls too.