Fix DB hash tables not expanding during RDB load#14789
Merged
ShooterIT merged 2 commits intoredis:unstablefrom Feb 14, 2026
Merged
Fix DB hash tables not expanding during RDB load#14789ShooterIT merged 2 commits intoredis:unstablefrom
ShooterIT merged 2 commits intoredis:unstablefrom
Conversation
🤖 Augment PR SummarySummary: Fixes a case where the RDB 🤖 Was this summary useful? React with 👍 or 👎 |
tezc
approved these changes
Feb 13, 2026
sundb
approved these changes
Feb 14, 2026
YaacovHazan
pushed a commit
that referenced
this pull request
Feb 23, 2026
In standalone mode, we create dicts on demand. by default, there is no dicts, and RESIZEDB hint doesn't expand dict actually. so we should create dict first when expanding if the dict does not exist.
kairosci
pushed a commit
to kairosci/redis
that referenced
this pull request
Mar 5, 2026
In standalone mode, we create dicts on demand. by default, there is no dicts, and RESIZEDB hint doesn't expand dict actually. so we should create dict first when expanding if the dict does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In standalone mode, we create dicts on demand. by default, there is no dicts, and RESIZEDB hint doesn't expand dict actually. so we should create dict first when expanding if the dict does not exist.
internal ticket: RED-182685
Note
Medium Risk
Touches core kvstore resizing behavior and RDB load path; while the change is small, it can affect memory allocation patterns and startup performance during loading.
Overview
Fixes a standalone-mode bug where the RDB
RESIZEDBhint could be ignored because per-slot kvstore dictionaries were allocated on-demand and not created duringkvstoreExpand, preventing actual hashtable expansion.kvstoreExpandnow skips indices first and then callscreateDictIfNeeded()before expanding,rdb.clogs a verbose message after applying the resize hint (including resulting bucket counts), andtests/integration/rdb.tcladds an integration test that saves/restores an RDB and asserts the resize log message appears.Written by Cursor Bugbot for commit fa037a5. This will update automatically on new commits. Configure here.