Add HOTKEYS HELP subcommand and fix hotkeys INFO section#14785
Merged
YaacovHazan merged 5 commits intoredis:unstablefrom Feb 23, 2026
Merged
Add HOTKEYS HELP subcommand and fix hotkeys INFO section#14785YaacovHazan merged 5 commits intoredis:unstablefrom
YaacovHazan merged 5 commits intoredis:unstablefrom
Conversation
🤖 Augment PR SummarySummary: This PR adds a missing Changes:
Technical Notes: HELP returns an array of strings describing HOTKEYS subcommands/arguments; INFO “Hotkeys” section is now gated at print-time on 🤖 Was this summary useful? React with 👍 or 👎 |
Collaborator
|
|
sundb
reviewed
Feb 11, 2026
YaacovHazan
requested changes
Feb 11, 2026
sundb
approved these changes
Feb 13, 2026
YaacovHazan
approved these changes
Feb 23, 2026
YaacovHazan
pushed a commit
that referenced
this pull request
Feb 23, 2026
Each command having subcommands needs a HELP subcommand which is currently missing for HOTKEYS. Also the newly added section "Hotkeys" for INFO was messing up modules INFOs in some cases. Fixed both issues in this PR.
kairosci
pushed a commit
to kairosci/redis
that referenced
this pull request
Mar 5, 2026
Each command having subcommands needs a HELP subcommand which is currently missing for HOTKEYS. Also the newly added section "Hotkeys" for INFO was messing up modules INFOs in some cases. Fixed both issues in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each command having subcommands needs a HELP subcommand which is currently missing for HOTKEYS.
Also the newly added section "Hotkeys" for INFO was messing up modules INFOs in some cases.
Fixed both issues in this PR.
Note
Low Risk
Adds a read-only help subcommand and a small null-safety/section-filtering fix in
INFO; behavior changes are localized and covered by tests.Overview
Adds a new
HOTKEYS HELPsubcommand (wired incommands.def, documented viacommands/hotkeys-help.json, and implemented inhotkeys.c) that returns server-side usage text for HOTKEYS parameters/subcommands.Fixes
INFOgeneration for the# Hotkeyssection inserver.cto be emitted even whenserver.hotkeysis NULL, but only include hotkeys fields when initialized, preventing unintended side effects on module INFO handling; tests were updated to assert modules aren’t called forINFO/INFO all/filtered sections and to track module InfoFunc invocation count (infotest.c/infotest.tcl).Written by Cursor Bugbot for commit d06adc0. This will update automatically on new commits. Configure here.