Skip to content

Add hotkeys memory to memory-overhead and fix hotkeys info keys#14711

Merged
minchopaskal merged 2 commits intoredis:unstablefrom
minchopaskal:hotkeys-info-fix
Jan 20, 2026
Merged

Add hotkeys memory to memory-overhead and fix hotkeys info keys#14711
minchopaskal merged 2 commits intoredis:unstablefrom
minchopaskal:hotkeys-info-fix

Conversation

@minchopaskal
Copy link
Copy Markdown
Collaborator

@minchopaskal minchopaskal commented Jan 19, 2026

Follow #14680
Add the memory overhead of the hotkeyStats structure to used_memory_overhead, add hotkeys- prefix to hotkey keys in INFO and remove used_memory in the hotkeys info section as it's unneeded (too little memory for us to care about).

Tnx @oranagra for pointing this out.

@minchopaskal minchopaskal requested a review from sundb January 19, 2026 14:35
@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Jan 19, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Jan 19, 2026

🤖 Augment PR Summary

Summary: Accounts for hotkeys tracking memory in Redis memory-overhead reporting and standardizes the INFO Hotkeys keys.

Changes:

  • Adds a `hotkeysGetMemoryUsage()` helper to estimate `hotkeyStats` memory (TopK structs + selected-slots array).
  • Includes hotkeys memory in `getMemoryOverheadData()` so it contributes to `used_memory_overhead`.
  • Updates the INFO Hotkeys section to use `hotkeys-` key prefixes and drops the (tiny) per-section used-memory field.

Technical Notes: This shifts hotkeys bookkeeping allocations from being implied “dataset” memory into the “overhead” bucket for MEMORY/INFO reporting.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@minchopaskal minchopaskal merged commit 1ab0cd2 into redis:unstable Jan 20, 2026
18 checks passed
fcostaoliveira pushed a commit to filipecosta90/redis that referenced this pull request Jan 21, 2026
…s#14711)

Add the memory overhead of the hotkeyStats structure to
`used_memory_overhead`, add `hotkeys-` prefix to hotkey keys in INFO and
remove `used_memory` in the hotkeys info section as it's unneeded (too
little memory for us to care about).

Tnx @oranagra for pointing
[this](redis#14680 (comment))
out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants