Skip to content

Conversation

@nosammai
Copy link
Contributor

Update CLUSTER FORGET docs for changes in #10869

Docs PR:
https://github.com/redis/docs/pull/1057/files

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@sundb sundb requested a review from ShooterIT January 21, 2025 11:46
@sundb
Copy link
Collaborator

sundb commented Jan 22, 2025

@nosammai please also run make and submit commands.def.

@sundb sundb merged commit f5e046a into redis:unstable Jan 27, 2025
18 checks passed
@oranagra
Copy link
Member

@sundb i happen to notice it and i think it's wrong.
please note #10398, we decided that the json files should only document interface changes.
changes of behavior can be documented in the docs repo

@sundb
Copy link
Collaborator

sundb commented Feb 21, 2025

@oranagra ohh, i misunderstood history.
In addition to interface change, the return format change I see is also recorded, is it also required? like xautoclaim

        "history": [
            [
                "7.0.0",
                "Added an element to the reply array, containing deleted entries the command cleared from the PEL"
            ]
        ],

@oranagra
Copy link
Member

yes, see this quote from the PR i linked above:

the command json documents should just include information about the "arguments" and the "outputs".

in that PR, Madelyn removed all the notes about behavior, and moved them to redis-doc

sundb added a commit to sundb/redis that referenced this pull request Feb 24, 2025
sundb added a commit that referenced this pull request Feb 24, 2025
As discussed in
#13749 (comment).
After #10398 we should record only the arguments and output changes in
the command history, while placing all others in the redis-doc, so
revert #13749.
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
Update CLUSTER FORGET docs for changes in
redis#10869

Docs PR:
redis/docs#1057

---------

Co-authored-by: debing.sun <debing.sun@redis.com>
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
…#13827)

As discussed in
redis#13749 (comment).
After redis#10398 we should record only the arguments and output changes in
the command history, while placing all others in the redis-doc, so
revert redis#13749.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants