Add Lua VM memory to memory overhead, now that it's part of zmalloc #13660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To complement the work done in redis#13133 contains some refactoring, and also a new field in MEMORY STATS additionally, clear scripts and stats between tests in external mode
|
|
Collaborator
|
@oranagra forget to add |
sundb
reviewed
Nov 20, 2024
sundb
approved these changes
Nov 21, 2024
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
…edis#13660) To complement the work done in redis#13133. it added the script VMs memory to be counted as part of zmalloc, but that means they should be also counted as part of the non-value overhead. this commit contains some refactoring to make variable names and function names less confusing. it also adds a new field named `script.VMs` into the `MEMORY STATS` command. additionally, clear scripts and stats between tests in external mode (which is related to how this issue was discovered)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complement the work done in #13133.
it added the script VMs memory to be counted as part of zmalloc, but that means they
should be also counted as part of the non-value overhead.
this commit contains some refactoring to make variable names and function names less confusing.
it also adds a new field named
script.VMsinto theMEMORY STATScommand.additionally, clear scripts and stats between tests in external mode (which is related to how this issue was discovered)