Skip to content

Fix set with invalid length causes smembers to hang #13515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sundb merged 3 commits into from
Sep 4, 2024
Merged

Fix set with invalid length causes smembers to hang #13515

sundb merged 3 commits into from
Sep 4, 2024

Conversation

@sundb
Copy link
Collaborator

@sundb sundb commented Sep 4, 2024 •
edited
Loading

After #13499, If the length set by addReplySetLen() does not match the actual number of elements in the reply, it will cause protocol broken and result in the client hanging.

failed CI: https://github.com/redis/redis/actions/runs/10692581371

@sundb sundb requested a review from fcostaoliveira September 4, 2024 02:56
@sundb sundb mentioned this pull request Sep 4, 2024
Merged
@sundb
Copy link
Collaborator Author

sundb commented Sep 4, 2024

benchmark

taskset -c 10 ./src/redis-server --save ""

data prepration

SADD set:100 vyoomgwuzv xamjodnbpf ewomnmugfa ljcgdooafo pcxdhdjwnf djetcyfxuc licotqplim alqlzsvuuz ijsmoyesvd whmotknaff rkaznetutk ksqpdywgdd gorgpnnqwr gekntrykfh rjkknoigmu luemuetmia gxephxbdru ncjfckgkcl hhjclfbbka cgoeihlnei zwnitejtpg upodnpqenn mibvtmqxcy htvbwmfyic rqvryfvlie nxcdcaqgit gfdqdrondm lysbgqqfqw nxzsnkmxvi nsxaigrnje cwaveajmcz xsepfhdizi owtkxlzaci agsdggdghc tcjvjofxtd kgqrovsxce ouuybhtvyb ueyrvldzwl vpbkvwgxsf pytrnqdhvs qbiwbqiubb ssjqrsluod urvgxwbiiz ujrxcmpvsq mtccjerdon xczfmrxrja imyizmhzjk oguwnmniig mxwgdcutnb pqyurbvifk ccagtnjilc mbxohpancs lgrkndhekf eqlgkwosie jxoxtnzujs lbtpbknelm ichqzmiyot mbgehjiauu aovfsvbwjg nmgxcctxpn vyqqkuszzh rojeolnopp ibhohmfxzt qbyhorvill nhfnbxqgol wkbasfyzqz mjjuylgssm imdqxmkzdj oapbvnisyq bqntlsaqjb ocrcszcznp hhniikmtsx hlpdstpvzw wqiwdbncmt vymjzlzqcn hhjchwjlmc ypfeltycpy qjyeqcfhjj uapsgmizgh owbbdezgxn qrosceblyo sahqeskveq dapacykoah wvcnqbvlnf perfwnpvkl ulbrotlhze fhuvzpxjbc holjcdpijr onzjrteqmu pquewclxuy vpmpffdoqz eouliovvra vxcbagyymm jekkafodvk ypekeuutef dlbqcynhrn erxulvebrj qwxrsgafzy dlsjwmqzhx exvhmqxvvp

taskset -c 16-20 memtier_benchmark --command="SMEMBERS set:100"  --hide-histogram --test-time 180

unstable (de7f2f8):

ALL STATS
====================================================================================================
Type           Ops/sec    Avg. Latency     p50 Latency     p99 Latency   p99.9 Latency       KB/sec 
----------------------------------------------------------------------------------------------------
Smemberss    114063.61         1.74952         1.71900         3.42300         3.90300    193484.85 
Totals       114063.61         1.74952         1.71900         3.42300         3.90300    386969.70

this PR (-0.2%):

====================================================================================================
Type           Ops/sec    Avg. Latency     p50 Latency     p99 Latency   p99.9 Latency       KB/sec 
----------------------------------------------------------------------------------------------------
Smemberss    113766.89         1.75415         1.71900         3.43900         3.96700    192981.52 
Totals       113766.89         1.75415         1.71900         3.43900         3.96700    385963.05

@sundb sundb merged commit 74609d4 into redis:unstable Sep 4, 2024
@sundb sundb deleted the smembers_len_reply branch September 4, 2024 09:35
@sundb sundb mentioned this pull request Sep 10, 2024
Merged
4 tasks
funny-dog pushed a commit to funny-dog/redis that referenced this pull request Sep 17, 2025
@sundb
Fix set with invalid length causes smembers to hang (redis#13515)
d41e71d 
After redis#13499, If the length set by
`addReplySetLen()` does not match the actual number of elements in the
reply, it will cause protocol broken and result in the client hanging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oranagra oranagra oranagra approved these changes

+1 more reviewer

@fcostaoliveira fcostaoliveira fcostaoliveira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sundb @oranagra @fcostaoliveira