Skip to content

Fix incorrect lag and entries-read value with tombstone #13379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
artikell wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Fix incorrect lag and entries-read value with tombstone #13379

artikell wants to merge 4 commits into from

Conversation

@artikell
Copy link
Contributor

@artikell artikell commented Jun 30, 2024

fix: #13337
rebase: #13338

  • Fixed the incorrect entries-read count in the case of an empty stream.
  • Ensured the real-time accuracy of the entries-read value in XINFO, preventing inconsistencies between lag and entries-read. Consequently, the return results of some unit tests (UT) have been modified.
  • Fixed the counting error when last-id < max_deleted_entry_id < first_id.

sundb
sundb reviewed Jul 3, 2024
View reviewed changes
tests/unit/type/stream-cgroups.tcl
assert_equal [dict get $reply max-deleted-entry-id] "1-0"
assert_equal [dict get $reply entries-added] 1
assert_equal [dict get $group entries-read] {}
assert_equal [dict get $group entries-read] 1
Copy link
Collaborator

@sundb sundb Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it 1? i don't see any XREADGROUP command.

tests/unit/type/stream-cgroups.tcl

set reply [r XINFO STREAM x FULL]
set group [lindex [dict get $reply groups] 0]
assert_equal [dict get $group entries-read] {}
Copy link
Collaborator

@sundb sundb Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't it 2?

@YaacovHazan YaacovHazan added the release-notes indication that this issue needs to be mentioned in the release notes label Oct 13, 2024
@YaacovHazan YaacovHazan moved this from Pending to Todo in Redis 7.4 Backport Apr 21, 2025
@YaacovHazan YaacovHazan moved this from Todo to Pending in Redis 7.4 Backport Apr 21, 2025
@YaacovHazan YaacovHazan moved this from pending to Todo in Redis 7.2 Backport May 25, 2025
@YaacovHazan YaacovHazan moved this from Todo to pending in Redis 7.2 Backport May 25, 2025
@sundb sundb removed this from Redis 8.2 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundb sundb sundb left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

release-notes indication that this issue needs to be mentioned in the release notes

Projects

Redis Backlog
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Redis Streams XINFO Lag field

3 participants

@artikell @sundb @YaacovHazan