-
Notifications
You must be signed in to change notification settings - Fork 24.4k
dynamically list test files #13220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sundb
merged 5 commits into
redis:unstable
from
dev-jonghoonpark:feature/dynamically-list-test-files
May 30, 2024
Merged
dynamically list test files #13220
sundb
merged 5 commits into
redis:unstable
from
dev-jonghoonpark:feature/dynamically-list-test-files
May 30, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jonghoonpark <dev@jonghoonpark.com>
Collaborator
|
this PR is safe for merge. |
kangzixiang
approved these changes
May 22, 2024
Collaborator
|
@dev-jonghoonpark i fixed some failure due to the changes of unstable, please have a look if you have time, thanks. |
sundb
approved these changes
May 30, 2024
oranagra
added a commit
that referenced
this pull request
Jul 16, 2024
- when uploading server logs, make sure they don't overwrite each other. - sort the test units to get consistent order between them (following #13220) - backup and restore the entire server configuration, to protect one unit from config changes another unit performs
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
**Related issue** redis#13219 **Motivation** Currently we have to manually update the all_tests variable when introducing new test files. **Modification** I have modified it to list test files dynamically, but instead of modifying it to add all test files, I have modified it to only add only test files from the following 4 paths - unit - unit/type - unit/cluster - integration so that it doesn't deviate too much from what we already do **Result** - dynamically list test files to all_tests variable - close issue redis#13219 **Additional information** - removed `list-common.tcl` file and added `generate_largevalue_test_array` proc in `util.tcl`. because `list-common.tcl` is not a test file - There is an order dependency. So I added a code to the "Is a ziplist encoded Hash promoted on big payload?" test that resets hash-max-listpack-value to the default (64). --------- Signed-off-by: jonghoonpark <dev@jonghoonpark.com> Co-authored-by: debing.sun <debing.sun@redis.com>
funny-dog
pushed a commit
to funny-dog/redis
that referenced
this pull request
Sep 17, 2025
- when uploading server logs, make sure they don't overwrite each other. - sort the test units to get consistent order between them (following redis#13220) - backup and restore the entire server configuration, to protect one unit from config changes another unit performs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
state:to-be-merged
The PR should be merged soon, even if not yet ready, this is used so that it won't be forgotten
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#13219
Motivation
Currently we have to manually update the all_tests variable when introducing new test files.
Modification
I have modified it to list test files dynamically, but instead of modifying it to add all test files, I have modified it to only add only test files from the following 4 paths
so that it doesn't deviate too much from what we already do
Result
Additional information
list-common.tclfile and addedgenerate_largevalue_test_arrayproc inutil.tcl. becauselist-common.tclis not a test file