Fix that slot return in CLUSTER SHARDS should be integer #12561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unintentional change was introduced in redis#10536, we used to use addReplyLongLong and now it is addReplyBulkLonglong, revert it back the previous behavior. It's already released in 7.2, so it might be a breaking change.
Contributor
Author
|
discussion see #10536 (review) |
madolson
approved these changes
Sep 10, 2023
Contributor
But it was a breaking change in 7.2 as well. Since the adoption of 7.2 is still in its early phase, we should focus on making sure it is compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unintentional change was introduced in #10536, we used
to use addReplyLongLong and now it is addReplyBulkLonglong,
revert it back the previous behavior.
It's already released in 7.2, so it might be a breaking change.