add a new loglevel 'nothing' to disable logging #12133
Conversation
|
i'm not certain about it. but it might also not be very beneficial (log can already explode by the time someone finds the problem). |
|
I'm inclined to add this nothing config as well as go through the warnings and make sure they are all really warnings. |
enjoy-binbin
left a comment
There was a problem hiding this comment.
agree with madolson
for the record, we checked some WARNING logs earlier and downgraded it to NOTICE. in #10715
|
I also support addressing the root cause rather than providing a kill switch as a workaround. |
|
it's necessary to check the wrong logs level, but my main idea is we need a log switch, if the |
I'll also add that we operationally could have used a kill-switch as a work around when we added a log as a warning thinking it was an uncommon case but turned out to be logged extensively in certain operational events. The overhead of the config is really small, and it's not a useless operational tool. |
Co-authored-by: Madelyn Olson <34459052+madolson@users.noreply.github.com>
|
discussed in core-team meeting. |
We add a new loglevel 'nothing' to disable logging in redis#12133. This PR syncs that config change to sentinel. Because in redis#11214 we support modifying loglevel in runtime. Although I think sentinel doesn't need this nothing config, it's better to be consistent.
Users can record logs of different levels by setting the
loglevel. However, sometimes there are many logs even at the warning level, which can affect the performance of Redis.For example, when a user accesses the tls-port using a non-encrypted link, Redis will log lots of "# Error accepting a client connection: ...".
We can provide the ability to disable logging so that users can temporarily turn off logging and turn it back on after the problem is resolved.