Add missing since filed for new CLIENT NO-TOUCH command #11829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIENT NO-TOUCH added in redis#11483, but forgot to add the since field in the JSON file. This PR adds the since field to it with a value of 7.2.0
enjoy-binbin
commented
Feb 23, 2023
Contributor
Author
enjoy-binbin
left a comment
There was a problem hiding this comment.
btw, i guess we should check the all the basic fields in generate-command-code.py (or in the TCL test)
CharlesChen888
approved these changes
Feb 23, 2023
oranagra
approved these changes
Feb 23, 2023
Member
oranagra
left a comment
There was a problem hiding this comment.
i thought that checking these in build or test is complicated because some commands don't have this field, but actually i now see they all have it, so i wonder how this happened? @CharlesChen888 didn't you clone another file and modify it?
Contributor
|
If I remembered correctly, I cloned client-no-evict.json and modified it to no-touch. But the "since" field wasn't there since the first commit...I may have accidentally deleted it. |
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
CLIENT NO-TOUCH added in redis#11483, but forgot to add the since field in the JSON file. This PR adds the since field to it with a value of 7.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLIENT NO-TOUCH added in #11483, but forgot to add the since
field in the JSON file. This PR adds the since field to it
with a value of 7.2.0