Fix issues with listpack encoded set #11685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #11290 added listpack encoding for sets, but was missing two things: 1. Correct handling of MEMORY USAGE (leading to an assertion). 2. Had an uncontrolled scratch buffer size in SRANDMEMBER leading to OOM panic (reported in #11668). Fixed by copying logic from ZRANDMEMBER. note that both issues didn't exist in any redis release.
zuiderkwast
approved these changes
Jan 4, 2023
Contributor
zuiderkwast
left a comment
There was a problem hiding this comment.
Thanks for fixing. Sorry that this feature has caused so many problems.
note that both issues didn't exist in any redis release.
Fortunately!
enjoy-binbin
approved these changes
Jan 5, 2023
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
PR redis#11290 added listpack encoding for sets, but was missing two things: 1. Correct handling of MEMORY USAGE (leading to an assertion). 2. Had an uncontrolled scratch buffer size in SRANDMEMBER leading to OOM panic (reported in redis#11668). Fixed by copying logic from ZRANDMEMBER. note that both issues didn't exist in any redis release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11290 added listpack encoding for sets, but was missing two things:
srandmember#11668). Fixed by copying logic from ZRANDMEMBER.note that both issues didn't exist in any redis release.
The case of SRANDMEMBER in #11668 will now result in a hung likes in #11671 (instead of OOM panic), to be discussed in #11671
Both issues reported by @yype