redis-cli adds -4 / -6 options to determine IPV4 / IPV6 priority in DNS lookup #11315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cli adding -4 and -6 options Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Co-authored-by: Yossi Gottlieb <yossigo@gmail.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Contributor
|
I do not review the codes, but I have one question first, the option "-4" or "-6" is mandatory or there is another option without argument. |
Contributor
Author
|
They are all optional, when not passed in, the effect is the same as before |
zeekling
reviewed
Nov 27, 2022
zuiderkwast
approved these changes
Dec 12, 2023
yossigo
approved these changes
Dec 24, 2023
roggervalf
pushed a commit
to roggervalf/redis
that referenced
this pull request
Feb 11, 2024
…NS lookup (redis#11315) This PR, we added -4 and -6 options to redis-cli to determine IPV4 / IPV6 priority in DNS lookup. This was mentioned in redis#11151 (comment) For now it's only used in CLUSTER MEET. The options also made it possible to reliably test dns lookup in CI, using this option, we can add some localhost tests for redis#11151. The commit was cherry-picked from redis#11151, back then we decided to split the PR. Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, we added -4 and -6 options to redis-cli to determine
IPV4 / IPV6 priority in DNS lookup.
This was mentioned in #11151 (comment)
For now it's only used in CLUSTER MEET.
The options also made it possible to reliably test dns lookup in CI,
using this option, we can add some localhost tests for #11151.
The commit was cherry-picked from #11151, back then we decided to split the PR.