Skip to content

Adds historical note about lower-case geo units support #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oranagra merged 1 commit into from
Aug 21, 2022
Merged

Adds historical note about lower-case geo units support #11162

oranagra merged 1 commit into from
Aug 21, 2022

Conversation

@itamarhaber
Copy link
Member

@itamarhaber itamarhaber commented Aug 21, 2022

@itamarhaber itamarhaber requested a review from guybe7 August 21, 2022 13:50
@itamarhaber itamarhaber mentioned this pull request Aug 21, 2022
Closed
@oranagra
Copy link
Member

oranagra commented Aug 21, 2022

i see this was part of #9656, but that we forgot to mention it in the release notes.

    ### Somehow related changes
    1. Literals should be in uppercase while placeholder in lowercase. Now all the GEO* command
       will be documented with M|KM|FT|MI and can take both lowercase and uppercase

@oranagra oranagra merged commit 31ef410 into redis:unstable Aug 21, 2022
@guybe7
Copy link
Collaborator

guybe7 commented Aug 21, 2022

@oranagra @itamarhaber it's the other way around
Redis <7 took only lower-case
Redis >=7 takes both

@itamarhaber
Copy link
Member Author

itamarhaber commented Aug 21, 2022

I'm so dense, sorry, you're totally right. I blame COVID and my fever.

@itamarhaber itamarhaber mentioned this pull request Aug 21, 2022
Merged
oranagra pushed a commit that referenced this pull request Aug 21, 2022
@itamarhaber
Changes "lower" to "capital" in GEO units history notes (#11164)
a534983 
A overlooked mistake in the #11162
oranagra pushed a commit that referenced this pull request Sep 21, 2022
@itamarhaber @oranagra
Adds historical note about lower-case geo units support (#11162)
dbb7337 
This change was part of #9656 (Redis 7.0)

(cherry picked from commit 31ef410)
@oranagra oranagra mentioned this pull request Sep 21, 2022
Merged
enjoy-binbin pushed a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
@itamarhaber @enjoy-binbin
Adds historical note about lower-case geo units support (redis#11162)
bf51324 
This change was part of redis#9656 (Redis 7.0)
enjoy-binbin pushed a commit to enjoy-binbin/redis that referenced this pull request Jul 31, 2023
@itamarhaber @enjoy-binbin
Changes "lower" to "capital" in GEO units history notes (redis#11164)
f86af3c 
A overlooked mistake in the redis#11162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oranagra oranagra oranagra approved these changes

@guybe7 guybe7 Awaiting requested review from guybe7

Assignees

No one assigned

Labels

None yet

Projects

Redis 7.0
Status: Done
Redis 7.0 Backport
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itamarhaber @oranagra @guybe7