tracking pending invalidation message of flushdb sent wrong #11068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trackingHandlePendingKeyInvalidations should use proto.
|
@huangzhw LGTM |
oranagra
approved these changes
Jul 31, 2022
Member
oranagra
left a comment
There was a problem hiding this comment.
in retrospect, we could have clearly seen that bug in the test.
oranagra
pushed a commit
that referenced
this pull request
Sep 21, 2022
trackingHandlePendingKeyInvalidations should use proto. (cherry picked from commit 61451b0)
oranagra
pushed a commit
that referenced
this pull request
Dec 12, 2022
trackingHandlePendingKeyInvalidations should use proto. (cherry picked from commit 61451b0)
enjoy-binbin
pushed a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
trackingHandlePendingKeyInvalidations should use proto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking pending invalidation message of flushdb sent by trackingHandlePendingKeyInvalidations should use proto.
This is caused by #11038.