Fix bgsaveerr issue in psync wrong offset test #11043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
reported in daily: https://github.com/redis/redis/runs/7511033997?check_suite_focus=true#step:7:4183 |
a903622 to
caa61e3
Compare
enjoy-binbin
commented
Jul 26, 2022
oranagra
reviewed
Jul 26, 2022
The kill above is sometimes successful and sometimes already too late. The PING in pysnc wrong offset test got rejected by bgsaveerr because lastbgsave_status is C_ERR. In theory, using diskless can avoid PING being affected, because when the replica is dropped, we will kill the child with SIGUSR1, and this will not affect lastbgsave_status. Anyway, this kill is not particularly needed here, dropping the kill is the best one, since we do have the waitForBgsave, so just let it take care of the bgsave. No need for fast termination.
eb1ec30 to
e23ac89
Compare
oranagra
approved these changes
Jul 27, 2022
Member
oranagra
left a comment
There was a problem hiding this comment.
for the record, i verified that with and without these kills, each of these tests takes roughly 100ms to complete.
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Sep 23, 2022
This change backports patch from upstream PR gentoo#11043 in order to properly solve bug #872278 reported for version 7.0.4 which affects version 7.0.5 as well. In upstream, the fix is not part of 7.0 branch, it is only present in unstable branch. Upstream-PR: redis/redis#11043 Bug: https://bugs.gentoo.org/860372 Bug: https://bugs.gentoo.org/872278 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Sep 25, 2022
This change backports patch from upstream PR #11043 in order to properly solve bug #872278 reported for version 7.0.4 which affects version 7.0.5 as well. In upstream, the fix is not part of 7.0 branch, it is only present in unstable branch. Upstream-PR: redis/redis#11043 Bug: https://bugs.gentoo.org/860372 Bug: https://bugs.gentoo.org/872278 Signed-off-by: Petr Vaněk <arkamar@atlas.cz> Signed-off-by: Sam James <sam@gentoo.org>
expeditioneer
pushed a commit
to expeditioneer/gentoo-portage
that referenced
this pull request
Sep 27, 2022
This change backports patch from upstream PR gentoo#11043 in order to properly solve bug #872278 reported for version 7.0.4 which affects version 7.0.5 as well. In upstream, the fix is not part of 7.0 branch, it is only present in unstable branch. Upstream-PR: redis/redis#11043 Bug: https://bugs.gentoo.org/860372 Bug: https://bugs.gentoo.org/872278 Signed-off-by: Petr Vaněk <arkamar@atlas.cz> Signed-off-by: Sam James <sam@gentoo.org>
oranagra
pushed a commit
that referenced
this pull request
Dec 12, 2022
The kill above is sometimes successful and sometimes already too late. The PING in pysnc wrong offset test got rejected by bgsaveerr because lastbgsave_status is C_ERR. In theory, using diskless can avoid PING being affected, because when the replica is dropped, we will kill the child with SIGUSR1, and this will not affect lastbgsave_status. Anyway, this kill is not particularly needed here, dropping the kill is the best one, since we do have the waitForBgsave, so just let it take care of the bgsave. No need for fast termination. (cherry picked from commit e714469)
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
The kill above is sometimes successful and sometimes already too late. The PING in pysnc wrong offset test got rejected by bgsaveerr because lastbgsave_status is C_ERR. In theory, using diskless can avoid PING being affected, because when the replica is dropped, we will kill the child with SIGUSR1, and this will not affect lastbgsave_status. Anyway, this kill is not particularly needed here, dropping the kill is the best one, since we do have the waitForBgsave, so just let it take care of the bgsave. No need for fast termination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kill above is sometimes successful and sometimes already too late.
The PING in pysnc wrong offset test got rejected by bgsaveerr because
lastbgsave_status is C_ERR.
In theory, using diskless can avoid PING being affected, because when
the replica is dropped, we will kill the child with SIGUSR1, and this
will not affect lastbgsave_status.
Anyway, this kill is not particularly needed here, dropping the kill
is the best one, since we do have the waitForBgsave, so just let it
take care of the bgsave. No need for fast termination.