Add pubsubshard_channels field in INFO STATS #10929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have `pubsub_channels` and `pubsub_patterns` in INFO stats, now add `pubsubshard_channels` (symmetry). Sharded pubsub was added in redis#8621
Member
|
@itamarhaber do you happen to know what this info is used for (other than maybe testing and debugging)? |
Member
|
No, but I would assume these can be used for monitoring the deployment's high-level activity. The |
Member
|
@redis/core-team please approve new info field or comment. |
oranagra
approved these changes
Jul 4, 2022
hpatro
approved these changes
Jul 4, 2022
itamarhaber
approved these changes
Jul 5, 2022
yossigo
approved these changes
Jul 5, 2022
Merged
enjoy-binbin
added a commit
to enjoy-binbin/redis
that referenced
this pull request
Jul 31, 2023
We already have `pubsub_channels` and `pubsub_patterns` in INFO stats, now add `pubsubshard_channels` (symmetry). Sharded pubsub was added in redis#8621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
pubsub_channelsandpubsub_patternsin INFO stats, now add
pubsubshard_channels(symmetry).Sharded pubsub was added in #8621